Add formula for gupnp-tools and subsequent dependencies #25113

Closed
wants to merge 5 commits into from

4 participants

@adammw

Adds formulas for:

  • gupnp-av 0.12.4
  • gupnp-tools 0.8.8
  • gnome-icon-theme 3.10.0
  • icon-naming-utils 0.8.90

Updates:

  • gupnp to version 0.20.8
@adamv

Please add formula one at a time, with no merge commits.

@adamv
Error Message

failed: brew audit gupnp-tools
Stacktrace

        Error: 1 problems in 1 formulae
gupnp-tools:
 * Trailing whitespace was found
@adammw

@adamv commits updated as per comments

@adamv

@BrewTestBot test this please

@adamv adamv commented on the diff Feb 14, 2014
Library/Formula/gupnp.rb
@@ -2,8 +2,8 @@
class Gupnp < Formula
homepage 'https://wiki.gnome.org/GUPnP/'
- url 'http://ftp.gnome.org/pub/GNOME/sources/gupnp/0.20/gupnp-0.20.3.tar.xz'
@adamv
adamv added a note Feb 14, 2014

This should have been submitted as a separate pull request. Does this new version work with upnp-router-control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv adamv commented on the diff Feb 14, 2014
Library/Formula/gupnp-tools.rb
+ depends_on 'xz' => :build
+ depends_on 'pkg-config' => :build
+ depends_on 'intltool' => :build
+ depends_on 'gettext'
+ depends_on 'gupnp'
+ depends_on 'gupnp-av'
+ depends_on 'gtk+3'
+ depends_on 'gnome-icon-theme'
+ depends_on 'ossp-uuid'
+
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}"
+ system "make", "install"
+ end
+end
@adamv
adamv added a note Feb 14, 2014

Need a hard newline at the end of the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv

Trying going to gupnp 0.20.10 and upnp-router-control didn't configure

@adamv

@Homebrew/owners any opinion on the upnp-router-control situation here?

@MikeMcQuaid
Homebrew member

@adamv If it's a core formula I guess we need to redact or fix before merging.

@cosmo0920

Currently, gnome-icon-theme 3.12.0 has been released.
It should update gnome-icon-theme Formula 3.12.0 from 3.10.0?

@adamv

I'm working on updating these.

@adamv

Debian has a patch for upnp-router-control, so merging these is unblocked.

@adamv

I've updated the versions here, and trying to run gupnp-av-cp fails with missing icons:

$ gupnp-av-cp 
Dynamic session lookup supported but failed: launchd did not provide a socket path, verify that org.freedesktop.dbus-session.plist is loaded!

(gupnp-av-cp:30268): Gtk-WARNING **: Could not find the icon 'network-workgroup'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
    http://icon-theme.freedesktop.org/releases

** (gupnp-av-cp:30268): WARNING **: Failed to load icon network-workgroup: Icon 'network-workgroup' not present in theme

** (gupnp-av-cp:30268): WARNING **: Failed to load icon gtk-network: Icon 'gtk-network' not present in theme
**
ERROR:icons.c:317:init_icons: assertion failed: (icons[i] != NULL)
Abort trap: 6
@adamv

Adding a dep on hicolor-icon-theme doesn't fix this, though possibly the icon cache isn't rebuilt correctly.

@adamv

Presumably this software ran correctly on your machine at the time of the pull request?

@adamv

Wondering if for gnome-icon-theme we need to update the cache for both gtk+2 and gtk+3. Alternately, we can make it gtk+3 only. The "missing" icons are clearly present in the theme.

@adamv

Using gtk+3 for gnome-icon-theme didn't fix gupnp-av-cp for me. I'm going to take the updates I have, but not pull gupnp-av or gupnp-tools. These will need an updated pull request that runs correctly for further consideration.

@adamv

Icons are loading now, mostly likely due to Jack's glib fix this afternoon.

@adamv

Pulled updated versions of these; sorry for the delay.

@adamv adamv closed this May 12, 2014
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.