[libstxxl] updated to 1.4.0 release #25163

Closed
wants to merge 1 commit into from

5 participants

@DennisOSRM

Updates the formula to today's 1.4.0 release. Simplifies formula as upstream patches were integrated into the release.

@MikeMcQuaid
Homebrew member

Doesn't build on 10.7/8.

@adamv
In file included from /tmp/libstxxl-dQJR/stxxl-1.4.0/lib/common/cmdline.cpp:13:
In file included from /tmp/libstxxl-dQJR/stxxl-1.4.0/include/stxxl/bits/common/cmdline.h:23:
In file included from /tmp/libstxxl-dQJR/stxxl-1.4.0/include/stxxl/bits/common/utils.h:30:
/tmp/libstxxl-dQJR/stxxl-1.4.0/include/stxxl/bits/compat/type_traits.h:20:10: fatal error: 'type_traits' file not found
#include <type_traits>

Is Xcode 4 / TR1 support still expected, or is this Xcode 5 only now?

@DennisOSRM

Already in contact with the maintainer

@MikeMcQuaid
Homebrew member

May just need appropriate fails_withs.

@mistydemeo

No core parts of STXXL require C++11.

And support marked back to GCC 3.x, so it should work with libstdc++.

@mistydemeo

@DennisOSRM Where is that conversation happening?

@DennisOSRM

@mistydemeo private mail exchange so far. Here's the gist:

clang defines GXX_EXPERIMENTAL_CXX0X by default which collides with the ifdefs in include/stxxl/bits/compat/type_traits.h

Most probably it suffices to reorder the checks in that file, but I don"t have a machine to test right now. I am supposed not to misuse the CI test machines for that, right?

@MikeMcQuaid
Homebrew member

Depends how quick the build is. If it only takes <5m then feel free.

@DennisOSRM

Appended a patch to the PR, but github appears to not pick it up automatically: https://github.com/DennisOSRM/homebrew/compare/libstxxl-1.4.0

@adamv

You need to git push -f to update here.

@MikeMcQuaid
Homebrew member

@adamv Think this is something weird with PRs post-migration, actually.

@adamv

@BrewTestBot test this please

@adamv adamv self-assigned this Mar 7, 2014
@adamv adamv added a commit that referenced this pull request Mar 8, 2014
@DennisOSRM DennisOSRM libstxxl 1.4.0
Closes #25163.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
6b64acd
@adamv adamv referenced this pull request Mar 8, 2014
Closed

libstxxl 1.4.0 #27317

@adamv

Doesn't seem to be working on 10.8 or 10.7: #27317

@adamv

Homepage says "Mac OS X - clang++ (3.3)" so presumably this should work on 10.8 with Xcode 5.

@adamv

This Cmake build is not specifying the install prefix, and this software is trying to install directly into /usr/local now instead of the prefix.

@adamv

This needs to be rebased on master for further review.

@adamv

Probably going to redact this entirely from the main repo.

@DennisOSRM

rebased to master.

@DennisOSRM DennisOSRM [libstxxl] updated to 1.4.0 release
fix compilation on 10.7 and 10.8

apply patch on old OS X versions, further include fixes for 10.7/10.8
f59084a
@DennisOSRM

also squashed into a single commit. Is there a way to trigger a rebuild by the jenkins bot?

@adamv

force-pushing retriggers the bot

@adamv

@Homebrew/owners can a maintainer with better knowledge of the C++11 DSL bits take a look at this?

@adamv adamv removed their assignment May 21, 2014
@mistydemeo

@BrewTestBot test this please

@mistydemeo

This fails on 10.7 and 10.8 still. Is it expected to build there?

See #29505 for what happens when they're built in C++11 mode.

@mistydemeo

The error:

/tmp/libstxxl-nYie/stxxl-1.4.0/include/stxxl/bits/compat/type_traits.h:33:7: error: no member named 'remove_const' in namespace 'std'; did you mean 'std::tr1::remove_const'?
using std::remove_const;
      ^~~~~~~~~~~~~~~~~
      std::tr1::remove_const
/usr/include/c++/4.2.1/tr1/type_traits:521:12: note: 'std::tr1::remove_const' declared here
    struct remove_const
           ^
@mistydemeo

Reported the issue upstream: stxxl/stxxl#7

@nijikon nijikon referenced this pull request Jun 8, 2014
Closed

libstxxl 1.4.0 #29980

@nijikon

@mikemcquaid We can close this, #29980 fixed it.

@MikeMcQuaid MikeMcQuaid closed this Jun 8, 2014
@MikeMcQuaid
Homebrew member

@nijikon In these cases add "Closes #25163" in the commit message, thanks!

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.