This repository has been archived by the owner. It is now read-only.

Add mcrypt formula #25551

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

jamel commented Dec 30, 2013

Current mcrypt formula actually delivers mcrypt library but not mcrypt / mdecrypt tools.
This pull request fixes that.

Owner

MikeMcQuaid commented Dec 30, 2013

Could we make the existing mcrypt formula install mcrypt and the tools?

Contributor

jamel commented Dec 30, 2013

Where I can read (or see examples) about several resources installation from one formula?

Owner

MikeMcQuaid commented Dec 30, 2013

grep for resource in the Formula directory.

Library/Formula/mcrypt.rb
option :universal
+ def patches
@adamv

adamv Dec 30, 2013

Contributor

Has this patch been sent upstream?

@jamel

jamel Dec 30, 2013

Contributor

No. It seems that it's only clang issue.

@MikeMcQuaid

MikeMcQuaid Dec 30, 2013

Owner

It still needs to go upstream.

@MikeMcQuaid

MikeMcQuaid Feb 13, 2014

Owner

Can you link the upstream submission here, ta.

@jamel

jamel Feb 14, 2014

Contributor

Done.

Library/Formula/mcrypt.rb
+ end
+
+ system "./configure", "--prefix=#{prefix}",
+ "--with-libmcrypt-prefix=#{prefix}"
@adamv

adamv Dec 30, 2013

Contributor

Align this with "--prefix

This still needs to go upstream.

Contributor

jamel commented Feb 13, 2014

I just updated the patch and sent it to mcrypt project.
https://sourceforge.net/p/mcrypt/patches/14/

Contributor

adamv commented Mar 10, 2014

Please add that link as a comment in the formula, and rebase this on master if needed.

Contributor

jamel commented Mar 10, 2014

Link was added

Did this get pushed yet? I did

brew install mcrypt

And when trying to use it in my C library, I get

dyld: lazy symbol binding failed: Symbol not found: _mcrypt_module_open
  Referenced from: /Users/mycomputer/Sites/aes/lib/aes/aes.bundle
  Expected in: flat namespace

Meaning the mcrypt tools are still not included ( Or so I believe.. )

@adamv adamv added the new formula label Apr 8, 2014

Contributor

jamel commented Apr 9, 2014

@MikeMcQuaid
Is there any reasons to not merge this PR? As I know the last merged build was failed because brew doctor fails on build host.

Owner

MikeMcQuaid commented Apr 9, 2014

@BrewTestBot test this please

Library/Formula/mcrypt.rb
+ url 'https://downloads.sourceforge.net/project/mcrypt/MCrypt/2.6.8/mcrypt-2.6.8.tar.gz'
+ sha1 '8ae0e866714fbbb96a0a6fa9f099089dc93f1d86'
+
+ depends_on 'mhash'
@MikeMcQuaid

MikeMcQuaid Apr 9, 2014

Owner

Use double-quotes on all new/changed lines and we're good to go.

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.