[Propose] Change 'Error: Already tapped' to 'Warning: Already tapped' #25617

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@sonots
Contributor
sonots commented Jan 3, 2014

This pull request is for #25511

@MikeMcQuaid
Member

This should probably change the original exception thrown instead. Also, I'm still against this change but only minorly. @Homebrew/owners thoughts?

@jacknagel
Contributor

With this change, are there any callers of install_tap that *don't* suppress this exception? I couldn't find any.

If that's the case, it should probably just return true/false (or handle the messaging itself).

@MikeMcQuaid
Member

Agreed.

@MikeMcQuaid MikeMcQuaid added a commit that closed this pull request Jan 3, 2014
@MikeMcQuaid MikeMcQuaid tap: never throw AlreadyTappedError.
Just make it a warning instead.

Closes #25511.
Closes #25617.
e901c92
@sonots
Contributor
sonots commented Jan 4, 2014

Thanks!!

@sonots sonots deleted the sonots:already_tapped_warning branch Jan 4, 2014
@ehershey ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014
@MikeMcQuaid @ehershey MikeMcQuaid + ehershey tap: never throw AlreadyTappedError.
Just make it a warning instead.

Closes #25511.
Closes #25617.
257aefb
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.