This repository has been archived by the owner. It is now read-only.

[Propose] Change 'Error: Already tapped' to 'Warning: Already tapped' #25617

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@sonots
Contributor

sonots commented Jan 3, 2014

This pull request is for #25511

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Jan 3, 2014

Member

This should probably change the original exception thrown instead. Also, I'm still against this change but only minorly. @Homebrew/owners thoughts?

Member

MikeMcQuaid commented Jan 3, 2014

This should probably change the original exception thrown instead. Also, I'm still against this change but only minorly. @Homebrew/owners thoughts?

@jacknagel

This comment has been minimized.

Show comment
Hide comment
@jacknagel

jacknagel Jan 3, 2014

Contributor

With this change, are there any callers of install_tap that *don't* suppress this exception? I couldn't find any.

If that's the case, it should probably just return true/false (or handle the messaging itself).

Contributor

jacknagel commented Jan 3, 2014

With this change, are there any callers of install_tap that *don't* suppress this exception? I couldn't find any.

If that's the case, it should probably just return true/false (or handle the messaging itself).

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Jan 3, 2014

Member

Agreed.

Member

MikeMcQuaid commented Jan 3, 2014

Agreed.

@sonots

This comment has been minimized.

Show comment
Hide comment
@sonots

sonots Jan 4, 2014

Contributor

Thanks!!

Contributor

sonots commented Jan 4, 2014

Thanks!!

@sonots sonots deleted the sonots:already_tapped_warning branch Jan 4, 2014

ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014

tap: never throw AlreadyTappedError.
Just make it a warning instead.

Closes #25511.
Closes #25617.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.