irods: link osxfuse and use :optional DSL #26086

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ghost
ghost commented Jan 22, 2014

Fix to link against osxfuse which I have overlooked and as it is optional it wasn't detected on bot.

@adamv
adamv commented Jan 22, 2014

See also #25497.

@adamv adamv closed this Jan 22, 2014
@adamv adamv reopened this Jan 22, 2014
@MikeMcQuaid
Member

@adamv Think we should note that the option name has changed e.g. like qt.rb does?

@adamv
adamv commented Jan 22, 2014

Don't know if this is worth pulling, honestly.

@ghost
ghost commented Feb 4, 2014

Is there anything else I can do here ? I have incorporated #26141.

@MikeMcQuaid MikeMcQuaid commented on the diff Feb 4, 2014
Library/Formula/irods.rb
inreplace 'config/config.mk', '# IRODS_FS = 1', 'IRODS_FS = 1'
inreplace 'config/config.mk', 'fuseHomeDir=/home/mwan/adil/fuse-2.7.0', "fuseHomeDir=#{HOMEBREW_PREFIX}"
chdir 'clients/fuse' do
- inreplace 'Makefile', 'lfuse', 'lfuse4x'
+ inreplace 'Makefile', 'lfuse', 'losxfuse'
+ inreplace 'Makefile', '-I$(fuseHomeDir)/include', '-I$(fuseHomeDir)/include/osxfuse'
@MikeMcQuaid
MikeMcQuaid Feb 4, 2014 Homebrew member

Gonna pull this as-is but would be good if you could submit it upstream.

@MikeMcQuaid
Member

@adamv Why not? Just wondering.

@adamv
adamv commented Feb 7, 2014

@mikemcquaid my opinion changed as the commits in here changed

@adamv adamv added a commit that closed this pull request Feb 7, 2014
Stefan irods: link osxfuse and use :optional DSL
Closes #26086.
Closes #26141.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
858af40
@adamv adamv closed this in 858af40 Feb 7, 2014
@ghost ghost deleted the unknown repository branch Feb 7, 2014
@ehershey ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014
Stefan irods: link osxfuse and use :optional DSL
Closes #26086.
Closes #26141.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
9037849
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.