valabind 0.8.0 #26936

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@dholm
Contributor
dholm commented Feb 23, 2014

No description provided.

@dholm
Contributor
dholm commented Feb 23, 2014

I think I need some help with this one. The compiler seems to ignore gobject_flags in the test step. I couldn't find any existing formulas that use pkg-config in the test step and my Ruby skills are somewhat limited.

@adamv
Contributor
adamv commented Feb 24, 2014

Audit warning:

Error Message

failed: brew audit valabind
Stacktrace

        Error: 1 problems in 1 formulae
valabind:
 * swig dependency should be "depends_on 'swig' => :build"
@dholm
Contributor
dholm commented Feb 25, 2014

@adamv I'm not sure how it reached that conclusion because valabind is sort of useless without swig.

@adamv
Contributor
adamv commented Feb 25, 2014

The auditor doesn't handle things that use swig at runtime very well.

@adamv
Contributor
adamv commented Mar 3, 2014

@Homebrew/owners any objections to this?

@MikeMcQuaid
Member

Should use double-quotes as per the Ruby Style Guide. Would be good to whitelist in audit before or when pulling.

@adamv
Contributor
adamv commented Mar 5, 2014

Test fails for me locally:

$ brew test -v valabind 
Testing valabind
==> valac -H vtest.vala -C --vapi=vtest.vapi --library=libvtest vtest.vala
vtest.vala:2.3-2.17: warning: method `VTest.Element.say' never used
  public void say(string str) {
  ^^^^^^^^^^^^^^^
Compilation succeeded - 1 warning(s)
==> /usr/bin/clang -fPIC -I/Users/adamv/homebrew/Cellar/glib/2.38.2/include/glib-2.0 -I/Users/adamv/homebrew/Cellar/glib/2.38.2/lib/glib-2.0/include -I/Users/adamv/.hb/opt/gettext/include -L/Users/adamv/homebrew/Cellar/glib/2.38.2/lib -L/Users/adamv/.hb/opt/gettext/lib -lgobject-2.0 -lglib-2.0 -lintl  -shared vtest.c -o libtest.so
vtest.c:5:10: fatal error: 'glib.h' file not found
#include <glib.h>

I have glib installed, but I don't have my install path set to /usr/local.

@dholm
Contributor
dholm commented Mar 5, 2014

@adamv Yes, I requested some help in the first comment but no feedback yet. "The compiler seems to ignore gobject_flags in the test step."

@adamv
Contributor
adamv commented Mar 5, 2014

I don't have any suggestion on how to fix the error, sorry.

@dholm
Contributor
dholm commented Mar 5, 2014

Ok, I'll remove the test case then.

@adamv adamv added a commit that closed this pull request Mar 8, 2014
@dholm @adamv dholm + adamv valabind 0.8.0
Closes #26936.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
06dbc8d
@adamv adamv closed this in 06dbc8d Mar 8, 2014
@ehershey ehershey added a commit to ehershey/homebrew that referenced this pull request Apr 4, 2014
@dholm @ehershey dholm + ehershey valabind 0.8.0
Closes #26936.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
5daa68e
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.