docker-osx formulae #26961

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@beorn

No description provided.

@MikeMcQuaid
Homebrew member

I'm 👎 on this given it's just a shell-script that seems to have e.g. hard-coded IP/docker location that users will need to edit. I'd suggest it goes to a tap or is just installed manually.

@beorn

No real need to edit the IP as it's the IP that the private VirtualBox instance will be set up to use.

@MikeMcQuaid
Homebrew member

On first run, it installs an OS X binary of the Docker client

This seems contradictory to us installing it as a dependency. By "docker location" I meant the /usr/local/bin/docker when it might not be there.

@adamv adamv added the new formula label Feb 24, 2014
@adamv

There's a 0.8.0 version now. Though that version also hard-codes the docker location. There are a couple ways to handle this. One is to set the docker location variable only if it isn't already set in the environment; then we can write a wrapper script that sets it to the Homebrew location. Or provide a caveat telling the user which ENV VAR to set.

@adamv

Passing on this until the docker location has been addressed.

@adamv adamv closed this Apr 12, 2014
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.