Work around C99 in MPlayer's libao2 #26992

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

dscho commented Feb 25, 2014

Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de

@dscho dscho Work around C99 in MPlayer's libao2
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
e851e80

@MikeMcQuaid MikeMcQuaid commented on the diff Feb 25, 2014

Library/Formula/mplayer.rb
@@ -35,6 +35,8 @@ def patches
else
# Fix compilation on 10.9, adapted from upstream revision r36500
p << "https://gist.github.com/jacknagel/7441175/raw/37657c264a6a3bb4d30dee14538c367f7ffccba9/vo_corevideo.h.patch"
+ # Fix C99-style 'for (int i=0...)'
+ p << "https://gist.githubusercontent.com/dscho/9210644/raw/16094d8d17b58689dec0e9f3a957fb2fd5744a9c/ao_coreaudio.c.patch"
@MikeMcQuaid

MikeMcQuaid Feb 25, 2014

Owner

Has this been submitted upstream? What's it fixing?

@dscho

dscho Feb 25, 2014

It has not been submitted upstream for lack of time. It is fixing the problem that I could not brew upgrade mplayer on my Snow Leopard because it would complain that for (int i=0;...) is not C89-compliant.

@MikeMcQuaid

MikeMcQuaid Feb 25, 2014

Owner

We'll need this submitted upstream before we can include it I'm afraid. Sorry.

@dscho

dscho Feb 25, 2014

No problem, I have a fix (and that's all I can afford to do at the moment).

Contributor

adamv commented Feb 25, 2014

Can we cram C99 into the ENV for Snow Leopard instead? I don't have a Snow Leopard machine for testing anymore.

Contributor

adamv commented Apr 15, 2014

This would need to be rebased on master for further review, but closing since it's not reported upstream.

adamv closed this Apr 15, 2014

xu-cheng locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.