This repository has been archived by the owner. It is now read-only.

Update play formula: add caveat #30262

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jubalh
Contributor

jubalh commented Jun 18, 2014

In Play 2.3 the play command has become the activator command. Play has
been updated to use Activator.

People should use typesafe-activator formula instead.

You can read more about this change at:
http://www.playframework.com/documentation/2.3.x/Migration23
and
http://www.playframework.com/documentation/2.3.x/Highlights23

Update play formula: add caveat
In Play 2.3 the play command has become the activator command. Play has
been updated to use Activator.

People should use typesafe-activator formula instead.

You can read more about this change at:
http://www.playframework.com/documentation/2.3.x/Migration23
and
http://www.playframework.com/documentation/2.3.x/Highlights23
@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Jun 18, 2014

Contributor

Is 2.3 out yet?

If so, then the proper course of action here is probably to move Play 2.2.x to homebrew-versions and then alias play to typesafe-activator or blacklist play with a message.

Contributor

adamv commented Jun 18, 2014

Is 2.3 out yet?

If so, then the proper course of action here is probably to move Play 2.2.x to homebrew-versions and then alias play to typesafe-activator or blacklist play with a message.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Jun 18, 2014

Contributor

Yes, it's out.
Alright, but I have never blacklisted anything and neither created an alias. What do I have to do? :)

Contributor

jubalh commented Jun 18, 2014

Yes, it's out.
Alright, but I have never blacklisted anything and neither created an alias. What do I have to do? :)

@jacknagel

This comment has been minimized.

Show comment
Hide comment
@jacknagel

jacknagel Jun 19, 2014

Contributor

To add to the blacklist, add a case to https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/blacklist.rb

We can't add an alias just yet as that would make brew uninstall play uninstall typesafe-activator, among other things.

Contributor

jacknagel commented Jun 19, 2014

To add to the blacklist, add a case to https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/blacklist.rb

We can't add an alias just yet as that would make brew uninstall play uninstall typesafe-activator, among other things.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Jun 19, 2014

Contributor

I added play to the blacklist. But I am uncertain what to do about the play.rb now. Looking forward to hear from you.

Contributor

jubalh commented Jun 19, 2014

I added play to the blacklist. But I am uncertain what to do about the play.rb now. Looking forward to hear from you.

@leepa

This comment has been minimized.

Show comment
Hide comment
@leepa

leepa Jun 19, 2014

Contributor

You'll need to git rm play.rb as part of adding to the blacklist (the whole point is the formula is removed).

This way Brew Bot won't go trying to build it! Make sure you then add the 2.2.x play.rb as play22.rb in the Homebrew Versions repo.

Contributor

leepa commented Jun 19, 2014

You'll need to git rm play.rb as part of adding to the blacklist (the whole point is the formula is removed).

This way Brew Bot won't go trying to build it! Make sure you then add the 2.2.x play.rb as play22.rb in the Homebrew Versions repo.

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Jun 19, 2014

Contributor

May want to copy the existing formula to https://github.com/Homebrew/homebrew-versions if you think people will need this specific version still.

Contributor

adamv commented Jun 19, 2014

May want to copy the existing formula to https://github.com/Homebrew/homebrew-versions if you think people will need this specific version still.

@leepa

This comment has been minimized.

Show comment
Hide comment
@leepa

leepa Jun 19, 2014

Contributor

Play 2.2 is still the main in use version for lots of modules. We should keep a copy.

On Thu, Jun 19, 2014 at 05:38 PM, Adam Vandenberg, wrote:

May want to copy the existing formula to https://github.com/Homebrew/homebrew-versions if you think people will need this specific version still.


Reply to this email directly or view it on GitHub:
#30262 (comment)

Contributor

leepa commented Jun 19, 2014

Play 2.2 is still the main in use version for lots of modules. We should keep a copy.

On Thu, Jun 19, 2014 at 05:38 PM, Adam Vandenberg, wrote:

May want to copy the existing formula to https://github.com/Homebrew/homebrew-versions if you think people will need this specific version still.


Reply to this email directly or view it on GitHub:
#30262 (comment)

@jubalh jubalh referenced this pull request Jun 19, 2014

Closed

Add play22.rb #462

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Jun 19, 2014

Contributor

I hope it's fine like that.
Also added it to homebrew-versions: Homebrew/homebrew-versions#462

Contributor

jubalh commented Jun 19, 2014

I hope it's fine like that.
Also added it to homebrew-versions: Homebrew/homebrew-versions#462

@leepa

This comment has been minimized.

Show comment
Hide comment
@leepa

leepa Jun 19, 2014

Contributor

👍

Perfect imho

Contributor

leepa commented Jun 19, 2014

👍

Perfect imho

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Jun 19, 2014

Contributor

Made a couple of style notes.

Contributor

adamv commented Jun 19, 2014

Made a couple of style notes.

@jacknagel jacknagel closed this in 5f88f5a Jun 20, 2014

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.