This repository has been archived by the owner. It is now read-only.

GCC: remove merged Tiger patch #31089

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
Contributor

jrtc27 commented Jul 24, 2014

As far as I can tell, the issue with _Unwind_GetIPInfo was fixed upstream before 4.9.1, so it is no longer required. Instead, I have added a patch which both fixes version_as_macro (it previously assumed there was only one digit for the minor OS version) and issues in libsanitizer relating to __DARWIN_64_BIT_INO_T. This patch is a modified version of https://gcc.gnu.org/bugzilla/attachment.cgi?id=32949.

Owner

MikeMcQuaid commented Jul 24, 2014

This needs to be accepted upstream before we'll accept it.

Contributor

jrtc27 commented Jul 24, 2014

Ok. Is it worth submitting a PR for just the first commit, as that has nothing to do with Yosemite?

Owner

MikeMcQuaid commented Jul 24, 2014

Yup you can just force-push to this branch and remove the second commit.

Contributor

jrtc27 commented Jul 24, 2014

Second commit removed.

Owner

MikeMcQuaid commented Jul 24, 2014

Also, might be good to know how you worked that out about the Tiger issue as the patch still seemed to apply. Thanks!

Contributor

jrtc27 commented Jul 24, 2014

The patch was a simple fix that plastered over the issue, i.e. it just disabled the specific feature since it was only applied when relevant. You can see the commit(s) which fixed it at https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=207611 and https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=207612 (they do the same thing, except one is for trunk and the other is for branches/gcc-4_8-branch). Checking the revision numbers shows that 4.9.1 was released after this patch (as was other releases), and just to make sure you can check that https://gcc.gnu.org/viewcvs/gcc/tags/gcc_4_9_1_release/ has the updated configuration scripts.

Now, I don't have a PPC Tiger system with which to check that the fix actually works, but you can see from the history of the issue (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58710) and the relevant patch (https://gcc.gnu.org/ml/gcc-patches/2014-02/msg00477.html) that others have said it fixes the issue.

Owner

MikeMcQuaid commented Jul 24, 2014

Sounds great. CC @mistydemeo.

Contributor

jrtc27 commented Jul 24, 2014

For the record, the same fix was included in 4.8.3.

So @jrtc27 what's the incantation to apply your patch here for those of us also running into this?

Contributor

jrtc27 commented Jul 24, 2014

The easiest way is probably to replace your gcc.rb with the one from jrtc27/homebrew@a94f371 (make sure you use brew edit, manually edit the .gitignore or do something else to ensure there are no conflicts when you next run brew update).

Hey thanks @jrtc27.

ghctim commented Jul 31, 2014

Will this be merged?

@adamv adamv added the 10.10 label Jul 31, 2014

@MikeMcQuaid MikeMcQuaid changed the title from GCC: Fix compiling on Yosemite to GCC: remove merged Tiger patch Aug 1, 2014

@MikeMcQuaid MikeMcQuaid removed the 10.10 label Aug 1, 2014

Owner

MikeMcQuaid commented Aug 1, 2014

I've updated the subject/label as this is no longer a 10.10 issue but a 10.4/Tiger one. I don't want to merge this in case it breaks GCC on Tiger so I'll let @mistydemeo do it when she has the chance.

Contributor

mistydemeo commented Aug 1, 2014

Thanks!

@mistydemeo mistydemeo closed this in 511d8a7 Aug 1, 2014

aerickson added a commit to aerickson/homebrew that referenced this pull request Aug 3, 2014

GCC: Tiger-specific patch was fixed upstream
Closes #31089.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

@jrtc27 jrtc27 deleted the jrtc27:gcc-patch branch Feb 11, 2016

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.