This repository has been archived by the owner. It is now read-only.

Added a formula for installing mvnvm, the Maven Version Manager (take 2) #34152

Closed
wants to merge 17 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@andrewswan

andrewswan commented Nov 13, 2014

This PR addresses the comments made against the previous PR for this new formula.

Andrew Swan and others added some commits Sep 5, 2014

@andrewswan

This comment has been minimized.

andrewswan commented Nov 13, 2014

class Mvnvm < Formula
homepage "http://mvnvm.org"
url "https://bitbucket.org/mjensen/mvnvm/get/0d4318ea71a2.tar.gz"
version "0.0.1-20141113"

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 13, 2014

Member

Please ask upstream for a tag.

end
conflicts_with 'maven',
:because => 'instead of installing Maven via Homebrew, you should use mvnvm to manage your Maven versions.'

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 13, 2014

Member

A bit too opinionated; should be just

installs a `mvn` binary
}
}
EOS
system "#{bin}/mvn", 'compile'

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 13, 2014

Member

👍 on a good test.

bin.install "mvn"
end
conflicts_with 'maven',

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 13, 2014

Member

Use double-quotes everywhere.

@PatrickRoumanoff

This comment has been minimized.

PatrickRoumanoff commented Nov 13, 2014

/cc @mjensen1

@andrewswan

This comment has been minimized.

andrewswan commented Nov 21, 2014

Do the committers need any more info before approving this PR? @jacknagel @MikeMcQuaid

end
conflicts_with "maven",
:because => "instead of installing Maven via Homebrew, you should use mvnvm to manage your Maven versions."

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 22, 2014

Member

conflicts_with "maven", :because => "also installs a 'mvn' executable"

url "https://bitbucket.org/mjensen/mvnvm/get/mvnvm-0.1.zip"
sha1 "ae75e26265c62daab4e9f751f5a6a44325247e23"
depends_on :java => "1.7"

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 22, 2014

Member

Add a newline after the above line.

depends_on :java => "1.7"
head do
url "https://bitbucket.org/mjensen/mvnvm/get/master.zip"

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 22, 2014

Member

Use just head "https://bitbucket.org/mjensen/mvnvm.git", put it above the depends_on

You may need to set JAVA_HOME for maven:
export JAVA_HOME=$(/usr/libexec/java_home)
EOS
end

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 22, 2014

Member

mvn will ask you for that so just remove these caveats.

}
EOS
system "#{bin}/mvn", "compile"
end

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Nov 22, 2014

Member

Great test.

@PatrickRoumanoff

This comment has been minimized.

PatrickRoumanoff commented Nov 24, 2014

Hi @MikeMcQuaid, I have updated the PR with the required changes.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.