Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Remove indefinite article from description #42333

Closed
wants to merge 1 commit into from
Closed

Remove indefinite article from description #42333

wants to merge 1 commit into from

Conversation

afh
Copy link
Contributor

@afh afh commented Aug 1, 2015

The changes were made with the following shell command:
for formula in $(grep -l 'desc "[Aa]n?\s' Library/Formula/*.rb); do
echo $formula
vim -c '/desc "/s/[Aa]n? //|normal f"gU2lZZ' $formula
done

The changes were made with the following shell command:
for formula in $(grep -l 'desc "[Aa]n\?\s' Library/Formula/*.rb); do
  echo $formula
  vim -c '/desc "/s/[Aa]n\? //|normal f"gU2lZZ' $formula
done
@MikeMcQuaid
Copy link
Member

@afh Cancelling the CI build. Please don't submit PRs that change lots (e.g. 5+) formula without notifying us as it messes with the bot.

@afh
Copy link
Contributor Author

afh commented Aug 1, 2015 via email

@MikeMcQuaid
Copy link
Member

Create an issue, ideally. If it's something like this that's running a script paste the script and maintainers may run it locally instead.

@xu-cheng
Copy link
Member

xu-cheng commented Aug 2, 2015

Thanks @afh. If you want, you can also submit a PR on desc audit rule.

@xu-cheng xu-cheng closed this in e21aaf6 Aug 2, 2015
@afh
Copy link
Contributor Author

afh commented Aug 2, 2015

@MikeMcQuaid That makes perfect sense.

@xu-cheng 👍 You're welcome. I'm uncertain what you mean by "submit[ting] a PR on desc audit rule."

@bfontaine
Copy link
Contributor

@afh What I think @xu-cheng means is you can submit a PR to add a brew audit rule on descs starting with an indefinite article.

@afh
Copy link
Contributor Author

afh commented Aug 3, 2015

@bfontaine Thanks for clarifying that.

@xu-cheng Here's the PR #42404.

oubiwann pushed a commit to lfe-support/homebrew that referenced this pull request Aug 7, 2015
The changes were made with the following shell command:
for formula in $(grep -l 'desc "[Aa]n\?\s' Library/Formula/*.rb); do
  echo $formula
  vim -c '/desc "/s/[Aa]n\? //|normal f"gU2lZZ' $formula
done

Closes Homebrew#42333.

Signed-off-by: Xu Cheng <xucheng@me.com>
oubiwann pushed a commit to lfe-support/homebrew that referenced this pull request Aug 7, 2015
The changes were made with the following shell command:
for formula in $(grep -l 'desc "[Aa]n\?\s' Library/Formula/*.rb); do
  echo $formula
  vim -c '/desc "/s/[Aa]n\? //|normal f"gU2lZZ' $formula
done

Closes Homebrew#42333.

Signed-off-by: Xu Cheng <xucheng@me.com>
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants