0install 2.8 #42405

afb · 2015-08-03T10:12:33Z

Another attempt, after the previous formula had several issues. Hopefully this is better...

MikeMcQuaid · 2015-08-03T10:23:31Z

Library/Formula/zero-install.rb

+
+  depends_on :gpg
+  depends_on "curl"
+  depends_on "gtk+" if build.with? "gui"


Use => :optional here instead, thanks.

How do I translate the :optional/:recommended over to the build option of using lablgtk or not ?
Should the GUI just be made mandatory, so that there is no way to install CLI only (skip gtk+)

The option will be named without-gtk+ instead. It should also probably default to off.

If I default it to off, it won't be in the bottle ? That was the main reason for leaving it on.
In other distributions, the GUI goes in a separate package: "0install" vs. "0install-core"

Yeh, we default to more minimal versions.

That is unfortunate (no gui bottle), since gtk+ is one of the more annoying ones.
But at least you can install that + deps (and ocaml/opam + boost) from bottles...

MikeMcQuaid · 2015-08-03T10:24:52Z

Maybe worth just having the non-head build in the formula first? Looks like the head build is quite a bit more complicated?

afb · 2015-08-03T10:38:17Z

Actually it is the non-head build that is complicated, due to the want of using resources...
The current build is as simple as (or it would be, if wasn't for the keg-only dependencies):

$ brew install pkg-config gettext gnupg gtk+ objective-caml opam
$ opam install yojson xmlm ounit react lwt extlib ocurl sha lablgtk
$ make
$ sudo make install

But that doesn't yield us any bottles, which means that users need to install ocaml/opam.
So as per the cookbook, the ocaml modules are locally vendored instead of dependencies.

Resources need to be versioned, however, so then it doesn't work with a HEAD build ?
But I can remove the head sections, and convert the "gui" flag over to :recommended...

MikeMcQuaid · 2015-08-03T10:42:11Z

Resources could potentially be unversioned Git repositories if they are only in the head do block.

afb · 2015-08-03T10:45:56Z

@MikeMcQuaid: the resources are all in the same repository, but I suppose that could be done too...

https://github.com/ocaml/opam-repository

DomT4 · 2015-08-14T01:47:34Z

Library/Formula/zero-install.rb

+    url "https://opam.ocaml.org/archives/lablgtk.2.18.3+opam.tar.gz"
+    version "2.18.3"
+    sha256 "f0b7ed0bd85f6cf4b4c5f81966f03763e76bb9f866f5172511ce48cf31fd433c"
+  end if build.with? "gtk+"


This should be:

if build.with? "gtk" resource "lablgtk" do url "https://opam.ocaml.org/archives/lablgtk.2.18.3+opam.tar.gz" version "2.18.3" sha256 "f0b7ed0bd85f6cf4b4c5f81966f03763e76bb9f866f5172511ce48cf31fd433c" end end

The end if lines are confusing and we've been trying to wipe them out for a while.

afb · 2015-08-15T07:24:23Z

Hope this isn't another one of those nit-pickings where just it ends up lying around in the end, like #28771

DomT4 · 2015-08-15T15:33:25Z

Referencing a PR that was some 15000 Issues/PRs back isn't terribly helpful. Maintainers want things to be as expected before going in otherwise at some point we end up having to fix them. If it meets maintainer's concerns & our minimum addition requirements, it will be merged.

As far as I can see, there's not much left to deal with before this is fine. Three nits, and we should be golden.

DomT4 · 2015-08-15T15:33:38Z

Library/Formula/zero-install.rb

+  sha256 "12de771be748bce9350c90bc4720029a566b078ceabd335af09386ac6a37df2b"
+
+  depends_on :gpg
+  depends_on "curl"


Is it incapable of using the system curl?

Nope, it should be "new enough". Dropping the curl then...

afb · 2015-08-15T15:40:35Z

@DomT4: ok, thanks.

seems like a missed one new dep-of-a-dep, and put the archives in the wrong place...
so pushed a new commit with that fixed. was trying to get gtk+ to build just the optional plugin,
but it seems that it doesn't work as a "build" dependency (doesn't pull in the deps like pango)
so the bottle will default to console-only, and needs a formula rebuild for the gui to work.

afb · 2015-08-15T16:08:31Z

@DomT4: seems like it doesn't download the resources on just brew install (not sure when, "fetch" ?)
so if you change a dependency it looks like it can go missing, just got a file-not-found at least.
trying to upgrade the formula to the later version (2.9), but also want to upgrade the ocaml modules...
and if there was a way to get the "gui_gtk.cmxs" (plugin bundle) to build, that would be great too.

afb · 2015-08-15T16:11:34Z

i.e. the :build doesn't work, because it only adds "gtk+" to the path but not "pango" and "glib" etc etc.
tried with ENV.append_path "PKG_CONFIG_PATH", "#{lib}/pkgconfig", but that hack didn't work either.

afb · 2015-08-15T16:16:22Z

ah, normally the stage is doing the fetch and verify. so need to add that line back to the formula.
(these resources are unpacked by opam, better let it handle it and get the suffix it prefers etc etc)

DomT4 · 2015-08-15T16:21:59Z

Funky. As long as it works, I'm happy to revert to the opam way mimicked previously.

afb · 2015-08-15T18:22:03Z

It was pointed out to me that build deps having broken pkg-config is a feature: #41759
So that probably means that we cannot build the gui in the bottle, but only conditionally

DomT4 · 2015-08-15T18:25:55Z

As long as it works optionally that's fine. We very rarely build GUIs by default anyhow.

Sent from my iPhone

On 15 Aug 2015, at 19:22, Anders F Björklund notifications@github.com wrote:

It was pointed out to me that build deps having broken pkg-config is a feature: #41759
So that probably means that we cannot build the gui in the bottle, but only conditionally

—
Reply to this email directly or view it on GitHub.

MikeMcQuaid · 2015-08-26T15:58:28Z

Library/Formula/zero-install.rb

+
+  def install
+    # Parallel builds fail for some of these opam libs.
+    ENV.deparallelize


Can you report issues upstream for these? Thanks!

Will do (as soon as I remember which of the modules it was that failed)
Hmm, build worked fine without it. Maybe the -j1 caution got outdated.

talex5 · 2015-10-07T17:25:53Z

What else needs to happen for this to get merged?

MikeMcQuaid · 2015-10-13T12:43:52Z

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

MikeMcQuaid reviewed Aug 3, 2015
View reviewed changes

afb force-pushed the 0install branch from 7f10ba5 to 6428fa7 Compare August 3, 2015 11:23

bfontaine added the new formula label Aug 3, 2015

afb force-pushed the 0install branch from 6428fa7 to fd51043 Compare August 4, 2015 12:14

DomT4 reviewed Aug 14, 2015
View reviewed changes

afb force-pushed the 0install branch from fd51043 to 05c2421 Compare August 15, 2015 07:21

afb force-pushed the 0install branch from 05c2421 to 3e731e2 Compare August 15, 2015 07:40

DomT4 reviewed Aug 15, 2015
View reviewed changes

afb force-pushed the 0install branch from 3e731e2 to bec819c Compare August 15, 2015 15:37

afb force-pushed the 0install branch from bec819c to 20b6669 Compare August 15, 2015 15:45

afb force-pushed the 0install branch from 20b6669 to 3b74517 Compare August 15, 2015 16:18

talex5 mentioned this pull request Aug 22, 2015

zero-install 2.6.2 (new formula) #28771

Closed

MikeMcQuaid reviewed Aug 26, 2015
View reviewed changes

0install 2.8

831eb3d

afb force-pushed the 0install branch from 3b74517 to 831eb3d Compare August 26, 2015 20:36

beurdouche mentioned this pull request Oct 2, 2015

New formula : FStar 0.9.0 #44341

Closed

MikeMcQuaid closed this in aab63bd Oct 13, 2015

Homebrew locked and limited conversation to collaborators Jul 10, 2016

0install 2.8 #42405

0install 2.8 #42405

afb commented Aug 3, 2015

MikeMcQuaid Aug 3, 2015

afb Aug 3, 2015

MikeMcQuaid Aug 3, 2015

afb Aug 3, 2015

MikeMcQuaid Aug 3, 2015

afb Aug 3, 2015

MikeMcQuaid commented Aug 3, 2015

afb commented Aug 3, 2015

MikeMcQuaid commented Aug 3, 2015

afb commented Aug 3, 2015

DomT4 Aug 14, 2015

afb commented Aug 15, 2015

DomT4 commented Aug 15, 2015

DomT4 Aug 15, 2015

afb Aug 15, 2015

afb commented Aug 15, 2015

afb commented Aug 15, 2015

afb commented Aug 15, 2015

afb commented Aug 15, 2015

DomT4 commented Aug 15, 2015

afb commented Aug 15, 2015

DomT4 commented Aug 15, 2015

MikeMcQuaid Aug 26, 2015

afb Aug 26, 2015

talex5 commented Oct 7, 2015

MikeMcQuaid commented Oct 13, 2015

0install 2.8 #42405

0install 2.8 #42405

Conversation

afb commented Aug 3, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeMcQuaid commented Aug 3, 2015

afb commented Aug 3, 2015

MikeMcQuaid commented Aug 3, 2015

afb commented Aug 3, 2015

Choose a reason for hiding this comment

afb commented Aug 15, 2015

DomT4 commented Aug 15, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afb commented Aug 15, 2015

afb commented Aug 15, 2015

afb commented Aug 15, 2015

afb commented Aug 15, 2015

DomT4 commented Aug 15, 2015

afb commented Aug 15, 2015

DomT4 commented Aug 15, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

talex5 commented Oct 7, 2015

MikeMcQuaid commented Oct 13, 2015