glyr 1.0.8 (new formula) and optional dependency in abcde #44364
Conversation
| class Glyr < Formula | ||
| desc "Music related metadata searchengine with command-line interface and C API" | ||
| homepage "https://github.com/sahib/glyr" | ||
|
|
There was a problem hiding this comment.
Please remove this empty line.
rwstauner
force-pushed
the
glyr
branch
3 times, most recently
from
2e049c9
to
ad4481d
Compare
|
If this library is too obscure that's fine. I hadn't heard of it myself until trying to use this new |
| end | ||
|
|
||
| test do | ||
| (out = testpath/"cover.txt").write("x") |
There was a problem hiding this comment.
Do you really need to create the file before running the command below?
There was a problem hiding this comment.
No, I suppose not. It's just an old habit of initializing it so you can be certain it changed during the test.
Is testpath a new directory every time?
There was a problem hiding this comment.
Removed and rebased. Thanks!
|
This is my first new formula so I appreciate you taking the time to comment. |
| test do | ||
| out = testpath/"cover.txt" | ||
| system "#{bin}/glyrc", "cover", "-D", "--artist", "Beatles", "--album", "Please Please Me", "-w", out | ||
| assert File.read(out).match(%r{^https?://}) |
There was a problem hiding this comment.
Please use assert_match %r{^https?://}, out.read here.
The getalbumart function keeps the program from running without glyr.
|
Notable enough, and important to have dependencies of our existing formula. Merged in b7b470a, thanks! |
|
Thanks! |
I'm not sure what the guidelines/preferences are for optional dependencies, but if your abcde config file specifies
getalbumartinACTIONSabcdewill refuse to run if it cannot findglyrc.