This repository has been archived by the owner. It is now read-only.

Pull the homebrew curl user agent from env #47265

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@nlesiecki

nlesiecki commented Dec 22, 2015

Certain proxies do user agent filtering, and it's helpful to be able to set the user agent. Homebrew overrides .curlrc with the -A flag, so un-override it.

nlesiecki
Pull the homebrew curl user agent from env
Certain proxies do user agent filtering, and it's helpful to be able to set the user agent. Homebrew overrides .curlrc with the -A flag, so un-override it.
@apjanke

This comment has been minimized.

Show comment
Hide comment
@apjanke

apjanke Dec 22, 2015

Contributor

If we're going to do this, should we name the variable HOMEBREW_USER_AGENT or HOMEBREW_HTTP_USER_AGENT? Our other env vars that allow users to configure brew's behavior seem to start with the HOMEBREW_ prefix, and I don't think USER_AGENT is a standard env var.

Contributor

apjanke commented Dec 22, 2015

If we're going to do this, should we name the variable HOMEBREW_USER_AGENT or HOMEBREW_HTTP_USER_AGENT? Our other env vars that allow users to configure brew's behavior seem to start with the HOMEBREW_ prefix, and I don't think USER_AGENT is a standard env var.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Dec 23, 2015

Member

This isn't the type of thing I'd like to be user-customisable as it doesn't allow upstreams to handle Homebrew correctly.

Member

MikeMcQuaid commented Dec 23, 2015

This isn't the type of thing I'd like to be user-customisable as it doesn't allow upstreams to handle Homebrew correctly.

@nlesiecki

This comment has been minimized.

Show comment
Hide comment
@nlesiecki

nlesiecki Dec 23, 2015

Mike what do you propose for a user like me who has to sit behind a proxy? Just not use Homebrew? that seems like a pretty poor outcome. What about appending to the User-Agent instead of overriding it?

nlesiecki commented Dec 23, 2015

Mike what do you propose for a user like me who has to sit behind a proxy? Just not use Homebrew? that seems like a pretty poor outcome. What about appending to the User-Agent instead of overriding it?

@nlesiecki

This comment has been minimized.

Show comment
Hide comment
@nlesiecki

nlesiecki Dec 23, 2015

I'm more than happy to work on a better idea.

nlesiecki commented Dec 23, 2015

I'm more than happy to work on a better idea.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Dec 23, 2015

Member

Tell your proxy provider that you need access to Homebrew. Alternatively, use a VPN or SSH tunnel.

Member

MikeMcQuaid commented Dec 23, 2015

Tell your proxy provider that you need access to Homebrew. Alternatively, use a VPN or SSH tunnel.

@ab

This comment has been minimized.

Show comment
Hide comment
@ab

ab Feb 5, 2016

@MikeMcQuaid This is not an option for a lot of people behind restrictive proxies. What exactly do you mean by "allow upstreams to handle Homebrew correctly"?

ab commented Feb 5, 2016

@MikeMcQuaid This is not an option for a lot of people behind restrictive proxies. What exactly do you mean by "allow upstreams to handle Homebrew correctly"?

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Feb 5, 2016

Member

@ab If upstream wants to block Homebrew clients: we need them to be able to do so. If your proxy provider wants to block Homebrew clients: we need them to be able to do so. Your issue is not with Homebrew but with your proxy provider.

Member

MikeMcQuaid commented Feb 5, 2016

@ab If upstream wants to block Homebrew clients: we need them to be able to do so. If your proxy provider wants to block Homebrew clients: we need them to be able to do so. Your issue is not with Homebrew but with your proxy provider.

@ab

This comment has been minimized.

Show comment
Hide comment
@ab

ab Feb 5, 2016

I'm having a hard time understanding your position: why do you think it's a good idea to remove users' freedom to run homebrew?

ab commented Feb 5, 2016

I'm having a hard time understanding your position: why do you think it's a good idea to remove users' freedom to run homebrew?

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Feb 5, 2016

Member

I think restrictive proxies are a terrible idea. Please ask the people who run your restrictive proxy why they think it's a good idea to stop users from using Homebrew (particularly if you need it to do your job). Homebrew is not the first and will not be the last piece of software that does not allow you to customise your user-agent so almost all software will have problems with your proxy.

Member

MikeMcQuaid commented Feb 5, 2016

I think restrictive proxies are a terrible idea. Please ask the people who run your restrictive proxy why they think it's a good idea to stop users from using Homebrew (particularly if you need it to do your job). Homebrew is not the first and will not be the last piece of software that does not allow you to customise your user-agent so almost all software will have problems with your proxy.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Feb 5, 2016

Member

And for why our user-agent should be consistent: If I’m paying for my bandwidth and some tarball on my server gets added to Homebrew: I start paying huge amounts of money for bandwidth and have no way to stop that if Homebrew’s user agent is not consistent.

Member

MikeMcQuaid commented Feb 5, 2016

And for why our user-agent should be consistent: If I’m paying for my bandwidth and some tarball on my server gets added to Homebrew: I start paying huge amounts of money for bandwidth and have no way to stop that if Homebrew’s user agent is not consistent.

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.