This repository has been archived by the owner. It is now read-only.

openssl: fix headers for universal build #47652

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@tdsmith
Contributor

tdsmith commented Jan 4, 2016

opensslconf.h is different depending on the architecture for which it is
built. Previously, universal builds installed only one version of the
header, which was wrong for one of the architectures. This uses #ifdef
magic to make sure that the correct version of the header is used for
the target against which client software is building.

https://langui.sh/2016/01/03/universal-libraries-but-not-headers/
illustrates this bug causing problems in the wild.

This should be pulled at the same time as #47650 so that it lands on an openssl bump. CI won't be informative here but it looks correct locally.

Ping @reaperhulk per conversation!

openssl: fix headers for universal build
opensslconf.h is different depending on the architecture for which it is
built. Previously, universal builds installed only one version of the
header, which was wrong for one of the architectures. This uses #ifdef
magic to make sure that the correct version of the header is used for
the target against which client software is building.

https://langui.sh/2016/01/03/universal-libraries-but-not-headers/
illustrates this bug causing problems in the wild.
@mistydemeo

This comment has been minimized.

Contributor

mistydemeo commented Jan 4, 2016

👍

@reaperhulk

This comment has been minimized.

Contributor

reaperhulk commented Jan 4, 2016

Tested locally and working. 👍

@MikeMcQuaid

This comment has been minimized.

Member

MikeMcQuaid commented Jan 4, 2016

👍

@tdsmith tdsmith closed this in a1272a4 Jan 11, 2016

@tdsmith tdsmith deleted the tdsmith:openssl-universal-headers branch Jan 11, 2016

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.