This repository has been archived by the owner. It is now read-only.

New Formula: little-cms2 and New Alias: lcms2 #7345

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
Contributor

potatosalad commented Aug 31, 2011

little-cms2 Formula and lcms2 Alias

Contributor

adamv commented Aug 31, 2011

Just a note for other maintainers, little-cms 1.x and 2.x have incompatible APIs.

Contributor

fish2000 commented Oct 6, 2011

@potatosalad -- awesome.

Contributor

2bits commented Jan 28, 2012

Indeed. I build lcms2 into my apps. Is this a candidate for devel do?

Contributor

jacknagel commented Jan 28, 2012

Given the long wait for lcms2, I would say yes.

Contributor

jacknagel commented Jan 29, 2012

@adamv @Sharpie @mistydemeo

Any objection to adding 2.x as the devel version here?

Contributor

adamv commented Jan 29, 2012

I dunno, we can add it, but perhaps a side-by-side lcms and lcms2 is what we'll have to do, since stuff won't stop depending on version 1, right?

Contributor

jacknagel commented Jan 29, 2012

I guess I'm fine with either.

Contributor

2bits commented Jan 29, 2012

That's a good question adamv. I was wrong to think that lcms2 would work as a devel block.
It really is a different library, using a different library name and includes, i.e.

nibbles$ ls -l /usr/local/include/lcms*.h
lrwxr-xr-x  1 nibbles  staff  40 Dec 22 11:39 /usr/local/include/lcms.h -> ../Cellar/little-cms/1.19/include/lcms.h
lrwxr-xr-x  1 nibbles  staff  41 Nov 24 01:01 /usr/local/include/lcms2.h -> ../Cellar/little-cms2/2.2/include/lcms2.h
lrwxr-xr-x  1 nibbles  staff  48 Nov 24 01:01 /usr/local/include/lcms2_plugin.h -> ../Cellar/little-cms2/2.2/include/lcms2_plugin.h


nibbles$ ls -l /usr/local/lib/liblcms*
lrwxr-xr-x  1 nibbles  staff  50 Dec 22 11:39 /usr/local/lib/liblcms.1.0.19.dylib -> ../Cellar/little-cms/1.19/lib/liblcms.1.0.19.dylib
lrwxr-xr-x  1 nibbles  staff  45 Dec 22 11:39 /usr/local/lib/liblcms.1.dylib -> ../Cellar/little-cms/1.19/lib/liblcms.1.dylib
lrwxr-xr-x  1 nibbles  staff  39 Dec 22 11:39 /usr/local/lib/liblcms.a -> ../Cellar/little-cms/1.19/lib/liblcms.a
lrwxr-xr-x  1 nibbles  staff  43 Dec 22 11:39 /usr/local/lib/liblcms.dylib -> ../Cellar/little-cms/1.19/lib/liblcms.dylib
lrwxr-xr-x  1 nibbles  staff  46 Nov 24 01:01 /usr/local/lib/liblcms2.2.dylib -> ../Cellar/little-cms2/2.2/lib/liblcms2.2.dylib
lrwxr-xr-x  1 nibbles  staff  40 Nov 24 01:01 /usr/local/lib/liblcms2.a -> ../Cellar/little-cms2/2.2/lib/liblcms2.a
lrwxr-xr-x  1 nibbles  staff  44 Nov 24 01:01 /usr/local/lib/liblcms2.dylib -> ../Cellar/little-cms2/2.2/lib/liblcms2.dylib

Openjpeg, libraw, dcraw, devil, etc: some prefer v1, others v2. So maybe we want two formulas for these different libraries, which I guess are badly named.

Contributor

mistydemeo commented Jan 29, 2012

Side-by-side seems like the best solution. Doesn't look like they clash.

Contributor

Sharpie commented Jan 30, 2012

Doesn't look like they clash.

If they don't install any overlapping headers/libs, then I have no problems with a separate lcms2 formula.

Contributor

2bits commented Jan 30, 2012

lcms2 is now at version 2.3 in case the OP wants to amend. It passes make check on Lion with both compilers.
@Sharpie I did a brew list of both packages, and there are no conflicts because they do more creative naming, e.g.:

/usr/local/Cellar/little-cms/1.19/bin/icclink
/usr/local/Cellar/little-cms/1.19/bin/icctrans
/usr/local/Cellar/little-cms/1.19/bin/jpegicc
/usr/local/Cellar/little-cms/1.19/bin/tiffdiff
/usr/local/Cellar/little-cms/1.19/bin/tifficc
/usr/local/Cellar/little-cms/1.19/bin/wtpt

/usr/local/Cellar/little-cms2/2.3/bin/jpgicc
/usr/local/Cellar/little-cms2/2.3/bin/linkicc
/usr/local/Cellar/little-cms2/2.3/bin/psicc
/usr/local/Cellar/little-cms2/2.3/bin/tificc
/usr/local/Cellar/little-cms2/2.3/bin/transicc
Contributor

jacknagel commented Jan 30, 2012

Haha. But good on them.

Contributor

jacknagel commented Jan 31, 2012

I'll bump it to 2.3 and pull this.

@jacknagel jacknagel closed this in 1880154 Jan 31, 2012

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

New formula: little-cms2
Given the API incompatibilities between 1.x an 2.x, it is easier to
maintain separate formulae for the time being. Luckily, the developers
have made sure that the two can be installed alongside each other: the
binaries have different names, the library is versioned, &c.

Closes #7345.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

New formula: little-cms2
Given the API incompatibilities between 1.x an 2.x, it is easier to
maintain separate formulae for the time being. Luckily, the developers
have made sure that the two can be installed alongside each other: the
binaries have different names, the library is versioned, &c.

Closes #7345.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.