Restore support for linking with -llua #7517

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

popq commented Sep 8, 2011

Adding versionless soft link in INSTALL_LIB to allow linking with -llua (see homebrew issue #6350 for an example)
(Related to name change in commit 9228a05)

@popq popq Adding versionless soft link in INSTALL_LIB to allow linking with -ll…
…ua (see homebrew issue #6350 for an example)

(Related to name change in commit 9228a05)
db2e3bf
Contributor

popq commented Sep 8, 2011

Successfully installed lua on my laptop, followed by highlight (which failed before this patch with ld complaining about library not found for -llua).

Contributor

nedos commented Sep 12, 2011

Hmm I really did do an issue search and missed yours. The only caveat I see is that you symlinked to a symlink as the 5.1.4.dylib is the only non-symlink. If you change that I'll close my request.

Contributor

popq commented Sep 12, 2011

I actually chose to link to the 5.1 symlink on purpose; the 5.1 link should be available for all 5.1.x versions of the library, removing the need to change the liblua.dylib link on every update. I am under the impression that this practise is quite common, at least where I'm coming from (linux). Any issues with this on os x that I should know about?

Contributor

popq commented Sep 12, 2011

Just to clarify for anyone looking at this for acceptance: @nedos solves the same problem in #7561, the only difference is which file we chose to have our symlinks point to: this patch to another symlink (liblua.5.1.dylib) for reasons stated above, @nedos to the actual library file (liblua.5.1.4.dylib), for other, probably just as good reasons. Both patches work fine.

Contributor

nedos commented Sep 12, 2011

Well put :) may the best patch win!

Still can't believe i overlooked your fix :D took me a while to figure out what was broken.

Contributor

dominickng commented Sep 15, 2011

This patch fixes the no Lua problem when install gnuplot on Lion 10.7.1 (#7642). :)

Contributor

popq commented Sep 15, 2011

...and the same problem when brewing highlight on Lion 10.7.1 (my initial need, same as closed (due to inactivity?) issue #6350)

Contributor

nedos commented Sep 15, 2011

...and imapfilter, which is why i began looking into this issue.

This fixes issue #7642 for me as well.

Sharpie closed this in 99d7889 Sep 15, 2011

@martinploeger martinploeger added a commit to martinploeger/homebrew that referenced this pull request Oct 8, 2011

@popq @martinploeger popq + martinploeger Lua: Ensure liblua.dylib is created
Adding versionless soft link in INSTALL_LIB to allow linking with -llua (see
homebrew issue #6350 for an example) (Related to name change in commit
9228a05).

Fixes #7642.
Fixes #6648.
Closes #7561.
Closes #7517.
Closes #6235.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
50aa19f

@Sharpie Sharpie added a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

@popq @Sharpie popq + Sharpie Lua: Ensure liblua.dylib is created
Adding versionless soft link in INSTALL_LIB to allow linking with -llua (see
homebrew issue #6350 for an example) (Related to name change in commit
9228a05).

Fixes #7642.
Fixes #6648.
Closes #7561.
Closes #7517.
Closes #6235.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
80e4c76

@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

@popq @Sharpie popq + Sharpie Lua: Ensure liblua.dylib is created
Adding versionless soft link in INSTALL_LIB to allow linking with -llua (see
homebrew issue #6350 for an example) (Related to name change in commit
9228a05).

Fixes #7642.
Fixes #6648.
Closes #7561.
Closes #7517.
Closes #6235.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
660cfd9

xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.