This repository has been archived by the owner. It is now read-only.

openimageio: Update to 1.0.3 #8458

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
9 participants
Contributor

2bits commented Nov 5, 2011

Updates openimageio to version 1.0.3.
Fix compilation against glew.
Fix compilation against qt.
Fix building of iv.
Add all deps to maximize the filetypes oiio can open.
Add a dep on a new formula, field3d.
Add a dep on a new formula, opencolorio.
Build iv & the python bindings.
Run the official testsuite if the user options it.

This compiles without error using llvm-2335.9, clang-2.0.139,
and gcc-4.2.1.5666 from XCode-4.0.2 on 64bit Snow Leopard.
It compiles without error using llvm-2336.9 and clang-3.1.318
on Lion 10.7.3 using XCode-4.3.1.

As of 1.0.3 all tests pass make test.

EDIT: add an include for zlib.h on Lion.
EDIT: switches tarball to 0.10.4, compiles on Lion, same xfails
in the testsuite (that only exists as a master on github).
EDIT: change the oiio-images url to a fixed commit tarball not
the master trunk tarball.
EDIT: add def initialize to oiio-images subformula to trigger
Homebrew's cache naming scheme, gets us oiioimages-1.0.0.tgz
EDIT: Change version to 0.10.5. Remove patch for boost-mt naming
because it works now. Still needs zlib patch, been reported.
Both previous test fails are fixed. There is a new one.
EDIT: Inline the d variable.
EDIT: Remove HR, shorten option.
EDIT: Move inline patch to a DATA block.
EDIT: Change to version 0.10.6.
EDIT: Change to version 1.0.0. Add devel block.
EDIT: Remove patch merged upstream.
EDIT: Fix python bindings to mimic vtk.rb.
EDIT: Add a dep on new formula OpenColorIO (ocio).
EDIT: Add a dep on webp.
EDIT: Remove illogical which python-config test.
EDIT: Add a fixed commit from branch RB-1.0 as the devel block url.
EDIT: Remove hard coded path to openjpeg. Determine it instead.
EDIT: Upgrade to 1.0.2. Shorten some comments.
EDIT: Remove code to find OpenJpeg. It just works now.
EDIT: Add head url. Remove Doxygen dep. It already makes a pdf.
EDIT: Remove python option. Just let it build that (10sec extra).
EDIT: Upgrade stable to 1.0.3, devel to 1.0.3a (bugfxes).

@ghost

ghost commented Nov 28, 2011

Any info on when this will appear in the master?

openimageio 0.10.2 will not build on Lion because it comes with libpng15 which does not automatically include zlib.h anymore. This is fixed in the master of openimageio so adding a head directive to your formula may work (my edit is still compiling all other deps as head)...

Ref: https://github.com/OpenImageIO/oiio/blob/master/src/ico.imageio/icooutput.cpp

Contributor

2bits commented Nov 29, 2011

Thanks for the heads up on the Lion fails. When I authored this formula, I didn't have it.
Now that we are forced to use a new boost, I will revisit this and get it working on SL and Lion.
I can patch things to include zlib.h within the formula. I just fixed the same thing in openjpeg.

Awesome, I guess new OSes just takes some time to support.. :)

Contributor

2bits commented Dec 2, 2011

Last commit adds a zlib.h so it compiles on Lion & Snow Lep with any compiler.

@maxpersson don't expect this to be pulled after it's been ignored for a month. I certainly don't, but I apologize if I raised anyone's hopes. I'm even more sorry that a fellow github group gets left with a b0rked formula after they've worked so hard on their software. The two weeks I spent crafting this and the Field3D one was just my way of saying thanks to International Light & Magic. I still get goosebumps when I remember sitting in the Cinema Theater in Marin County, as Empire Strikes Back started and that music ignited the most amazing cheer from the audience. Those were the days.

maxekman commented Dec 2, 2011

Thats great! I just use your formula in the meantime. Thanks for your effort!

Too bad it takes so long time for the formulas to appear in the master...

Rio commented Jan 20, 2012

Is this already in the homebrew tree? I still can't compile it through brew install openimageio.

[ 69%] Building CXX object libOpenImageIO/CMakeFiles/OpenImageIO.dir/**/ptex.imageio/ptex/PtexSeparableKernel.cpp.o
make[2]: * [libOpenImageIO/CMakeFiles/OpenImageIO.dir//ico.imageio/icooutput.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [libOpenImageIO/CMakeFiles/OpenImageIO.dir/all] Error 2
make: *** [all] Error 2
==> Exit Status: 2
http://github.com/mxcl/homebrew/blob/master/Library/Formula/openimageio.rb#L33
==> Environment
HOMEBREW_VERSION: 0.8.1
HEAD: ed07a0f
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
Hardware: 8-core 64-bit sandybridge
OS X: 10.7.2
Kernel Architecture: x86_64
Ruby: 1.8.7-249
/usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby
Xcode: 4.2.1
GCC-4.0: N/A
GCC-4.2: N/A
LLVM: build 2336
Clang: 3.0 build 211
MacPorts or Fink? false
X11 installed? true
==> Build Flags
CC: /usr/bin/llvm-gcc => /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2
CXX: /usr/bin/llvm-g++ => /usr/llvm-gcc-4.2/bin/llvm-g++-4.2
LD: /usr/bin/llvm-gcc => /usr/llvm-gcc-4.2/bin/llvm-gcc-4.2
CFLAGS: -O3 -w -pipe -march=core2 -msse4
CXXFLAGS: -O3 -w -pipe -march=core2 -msse4
MAKEFLAGS: -j8

Error: Failed executing: make install

Contributor

2bits commented Jan 23, 2012

They never pulled this, sorry.

@mistydemeo mistydemeo commented on an outdated diff Jan 23, 2012

Library/Formula/openimageio.rb
@@ -1,36 +1,95 @@
require 'formula'
+class J2kp4files < Formula
+ url 'http://pkgs.fedoraproject.org/repo/pkgs/openjpeg/j2kp4files_v1_5.zip/27780ed3254e6eb763ebd718a8ccc340/j2kp4files_v1_5.zip'
+ md5 '27780ed3254e6eb763ebd718a8ccc340'
+end
+
+class Tiffpic < Formula
+ url 'ftp://ftp.remotesensing.org/pub/libtiff/pics-3.8.0.tar.gz'
+ sha1 'f50e14335fd98f73c6a235d3ff4d83cf4767ab37'
+end
+
+class OiioImages < Formula
+ url 'https://github.com/OpenImageIO/oiio-images/tarball/master'
@mistydemeo

mistydemeo Jan 23, 2012

Contributor

Hm, I see there's no stable version. Can we choose a specific commit rather than use master though? e.g. https://github.com/OpenImageIO/oiio-images/tarball/3819677a7fa603f7ffc1172faceb9b4e958b7e44

Contributor

mistydemeo commented Jan 23, 2012

@2bits, I'm sorry this didn't get looked at earlier. Looking over it.

Contributor

2bits commented Jan 23, 2012

I haven't looked at it in a month or two to test how it's working, but I think at the time there was only a head for the oiio test images. I'll test this again.

Contributor

mistydemeo commented Jan 23, 2012

If there's only a head for those test images that's OK, I'd just rather point to a known-good revision instead of a master branch that can change without notice.

Contributor

2bits commented Jan 23, 2012

The above commit:

  • Updates the formula to build version 0.10.4 of this software.
  • Modifies the sha1 for the new version.

I looked into the oiio-images project on github, which notes on their homepage that they're still organizing the repo.
So as of late January, we are using the only tarball. In reply to your inline suggestion of using a specific commit for the oiio-images tarball rather than a master tarball, I don't know how to accomplish that in the formula. On a related note, the testsuite still fails those two tests. They may not be corrected until 0.11.0 iirc.

Contributor

mistydemeo commented Jan 23, 2012

Github only provides a button for a tarball from the latest commit in a branch, which will change depending on whatever that latest commit is. But they can actually serve a tarball from a specific commit using the right URL format. This URL goes to the current latest commit on master, and won't change without notice:
https://github.com/OpenImageIO/oiio-images/tarball/3819677a7fa603f7ffc1172faceb9b4e958b7e44

Contributor

2bits commented Jan 24, 2012

Ok that url gets me the specific tarball and works, but is there a trick to getting its output name in the cache something
better than 3819677a7fa603f7ffc1172faceb9b4e958b7e44? My above commit only creates a file called master. So I'm curious how to do it while sticking to Homebrew's builtin download strategies (I don't want to recreate the wheel, hand crafting a curl and checking if the tarball exists in the cache and doing a sha1 digest etc).

Contributor

mistydemeo commented Jan 24, 2012

The download name isn't customizable. No matter what the name is on the original server, it will always be renamed to Formulaname-version.ext. Since it'll have the formula name, it shouldn't be too hard to find. If you think the full hash is too long, you can specify a version of 3819677a7f - the short hash is good enough and is definitely easier on the eyes.

Contributor

2bits commented Jan 24, 2012

The file gets stored with a name consisting of only the commit numbers, e.g.:

/Users/nibbles/Library/Caches/Homebrew/3819677a7fa603f7ffc1172faceb9b4e958b7e44

Is that the best I can do? It's feels like I'm forgetting something because I've been afk.
The lack of a .tar.gz makes it hard to manage the file. I think it has something to do
with the lack of version number, as evidenced by my last commit creating a file called:

/Users/nibbles/Library/Caches/Homebrew/master

Contributor

2bits commented Feb 19, 2012

Just noticed I never pushed a new commit with your request to fix the oiio-images url. It's on the way...

Contributor

2bits commented Feb 19, 2012

Well I fixed the url and decided to go hog wild and rebase. How does that work for you @mistydemeo?

Contributor

2bits commented Feb 21, 2012

@jacknagel @mistydemeo please review. I did a rebase, switched to the new 0.10.5

Contributor

2bits commented Feb 21, 2012

@adamv I made that variable inline as your requested. It looks much better and works well.

Contributor

adamv commented Feb 21, 2012

If a maintainer wants to smoke-test this, let me know; otherwise I'll probably pull blindly as I don't want to do a lengthy test compile.

@mistydemeo mistydemeo and 1 other commented on an outdated diff Feb 21, 2012

Library/Formula/openimageio.rb
- depends_on 'tbb' => :optional
+ def options
+ [
+ [ '--gui', 'Build the gui named iv using qt and glew' ],
+ [ '--with-tests', <<-EOS.undent
+ Download 60MB of test images and run the testsuite against them.
+ There are 1:23 fails, in texture-fat, which is being reported.
+ Only run --with-test for debugging purposes, as the failed test
@mistydemeo

mistydemeo Feb 21, 2012

Contributor

Should be --with-tests ;)

@mistydemeo

mistydemeo Feb 21, 2012

Contributor

Also - could we get a link to the upstream issue? Thanks!

@adamv

adamv Feb 21, 2012

Contributor

Also, that's way too long for an option description.

@jacknagel jacknagel commented on an outdated diff Feb 21, 2012

Library/Formula/openimageio.rb
+ md5 '27780ed3254e6eb763ebd718a8ccc340'
+end
+
+class Tiffpic < Formula
+ url 'ftp://ftp.remotesensing.org/pub/libtiff/pics-3.8.0.tar.gz'
+ sha1 'f50e14335fd98f73c6a235d3ff4d83cf4767ab37'
+end
+
+class OiioImages < Formula
+ url 'https://github.com/OpenImageIO/oiio-images/tarball/3819677a7f'
+ sha1 'f7ab99d2dbc1835ce43fd8e5e69555bebd750ad7'
+ version '1.0.0'
+ def initialize; super "oiioimages"; end
+end
+
+#-----------------------------------------------------------------------
@jacknagel

jacknagel Feb 21, 2012

Contributor

Style nit: remove this.

Contributor

2bits commented Feb 21, 2012

Good eyes.

@mistydemeo mistydemeo commented on an outdated diff Feb 21, 2012

Library/Formula/openimageio.rb
def install
- # Allow compilation against boost 1.46.0
- # See https://github.com/OpenImageIO/oiio/issues/37
- inreplace "src/libOpenImageIO/imageioplugin.cpp",
- "#include <boost/filesystem.hpp>",
- "#define BOOST_FILESYSTEM_VERSION 2\n#include <boost/filesystem.hpp>"
-
- # Add include path for libpng explicitly
- system "cmake src/ #{std_cmake_parameters} -DUSE_QT:BOOL=OFF -DEMBEDPLUGINS:BOOL=ON -DCMAKE_CXX_FLAGS=-I/usr/X11/include"
- system "make install"
+ # Fix zlib.h not in libpng on Lion. Issue is reported upstream.
+ if MacOS.lion? then
@mistydemeo

mistydemeo Feb 21, 2012

Contributor

Can we get this as a patch instead of an inreplace?

If the code here changes in a later release it'll break the patch - which is good, because it prods whoever's updating the formula that it may no longer be necessary.

(I see that the libpng fix is in the upstream source, but didn't make it into this release. I guess the comment can be updated to reflect that it will not be necessary in a future version.)

Contributor

mistydemeo commented Feb 21, 2012

@adamv I ran the make test with llvm-gcc and clang. As expected, I had 1 failure and 22 successes; so, looks good.

@2bits, you should be able to use a rescue clause on the make test to prevent brew install from bailing out on the failed test.

@mistydemeo mistydemeo and 1 other commented on an outdated diff Feb 21, 2012

Library/Formula/openimageio.rb
@@ -1,35 +1,85 @@
require 'formula'
+class J2kp4files < Formula
+ url 'http://pkgs.fedoraproject.org/repo/pkgs/openjpeg/j2kp4files_v1_5.zip/27780ed3254e6eb763ebd718a8ccc340/j2kp4files_v1_5.zip'
+ md5 '27780ed3254e6eb763ebd718a8ccc340'
+end
+
+class Tiffpic < Formula
+ url 'ftp://ftp.remotesensing.org/pub/libtiff/pics-3.8.0.tar.gz'
+ sha1 'f50e14335fd98f73c6a235d3ff4d83cf4767ab37'
+end
+
+class OiioImages < Formula
+ url 'https://github.com/OpenImageIO/oiio-images/tarball/3819677a7f'
+ sha1 'f7ab99d2dbc1835ce43fd8e5e69555bebd750ad7'
+ version '1.0.0'
+ def initialize; super "oiioimages"; end
@mistydemeo

mistydemeo Feb 21, 2012

Contributor

Don't think this is necessary.

@jacknagel

jacknagel Feb 21, 2012

Contributor

Sorry, this came out of a different thread; Homebrew can't determine the name of subformula correctly, and so it just uses the URL basename in the cache; in this case, the cached filename is "3819677a7f". So it's not necessary, but it does make the cache a little nicer.

@mistydemeo

mistydemeo Feb 21, 2012

Contributor

Oh, I see - makes sense.

We should probably be using the class name instead of the URL basename.

Contributor

2bits commented Feb 21, 2012

People who are debugging want their prompt to investigate, not necessarily a rescue.

Contributor

2bits commented Feb 21, 2012

That moves the patch into a data block if you want to review it again.

Contributor

mistydemeo commented Feb 22, 2012

The patch looks good - thanks for the change.

I'm still uncomfortable about the option text length. What about something like:

"Download test images and run make test. 1/29 tests will fail."

Contributor

2bits commented Mar 12, 2012

@mistydemeo Hello. This is a new version. Enjoy the code when you have some time. 👋

Contributor

2bits commented Mar 16, 2012

@mistydemeo please review when you have some time. Our formula hasn't worked in a while.

Contributor

acdha commented Mar 16, 2012

@2bits: using your fork, I'm seeing openjpeg include errors. I have it installed & linked.

/tmp/homebrew-openimageio-1.0.0-Gvez/OpenImageIO-oiio-5b37f1c/src/jpeg2000.imageio/jpeg2000input.cpp:32:10: fatal error: 'openjpeg.h' file not found
#include <openjpeg.h>
         ^
Contributor

acdha commented Mar 16, 2012

After changing https://github.com/2bits/homebrew/blob/upOiio/Library/Formula/openimageio.rb#L87 to point to version 1.4 (current master version) the build worked. Seems like there should be a better way to determine the version - even if it's a hack like ls -1d #{ojpath}/include/openjpeg-*/ | head -1

Contributor

2bits commented Mar 16, 2012

You're right. I've been concerned it's a fail to hard code the openjpeg version in the include path. At one point I did what you suggested and was cutting the correct version number out of brew list --versions openjpeg or other times it was out of the keg path. I couldn't decide what was ruby enough, and that hard coded thing slipped in.

brew info openjpeg return 1.5.0 for me btw. Not sure how you sneaked in 1.4 :)
I will patch this, and thank you very much for bringing it up.

Contributor

acdha commented Mar 16, 2012

That was surprising indeed: I had openjpeg installed awhile ago. A brew upgrade resulted in 1.5 being installed with include/openjpeg-1.4/; after removing and reinstalling it is now correctly include/openjpeg-1.5/

Contributor

2bits commented Mar 17, 2012

And that should fix it for any version of openjpeg. I liked your method of determining the include directory, but I went for internal Ruby commands instead. Larry fixed a few bugs in the devel version, brew install --devel openimageio if you want.

Contributor

mistydemeo commented Mar 18, 2012

@2bits I'll pull when the opencolorio dep is ready, since this won't build without.

Contributor

2bits commented Mar 21, 2012

And there is 1.0.2. Very exciting. All tests pass, a couple of good bug fixes, backwards compatible, and rebased. The devel branch is starting to pop as the GSoC people throw it down.

Contributor

2bits commented Apr 10, 2012

@mistydemeo Do you have some time to review this? Thanks.

Contributor

mistydemeo commented Apr 10, 2012

I do indeed, and apologies for missing this when I pulled ocio.

Contributor

mistydemeo commented Apr 10, 2012

Looking good on Lion, just going to give it a test run on my 10.6 box tomorrow.

Contributor

2bits commented Apr 10, 2012

Thanks for the review.

Contributor

2bits commented Apr 10, 2012

@mistydemeo The thing I'm still not satisfied with is the whole OpenJpeg header issue. It's a hack because

  1. Homebrew tells me the include is /usr/local/Cellar/openjpeg/1.5.0/include when it is actually /usr/local/Cellar/openjpeg/1.5.0/include/openjpeg-1.5

  2. If I add a head clause that it needs because it's actively developed here on Github, then Homebrew changes that to be /usr/local/Cellar/openjpeg/HEAD/include which never exists.

So I have the worst time mucking with that library. But as the formula is now, it works around these two problems by determining the openjpeg-1.5 directory and not building HEAD. So I may edit this again if I can think of a way to craft HEAD. Jack once told me about linked_keg.realpath. So that will probably be the fix. Do you agree it would be worth making that adjustment now? If we did, the formula would be much more stable. That devel block gets outdated rapidly as it is now.

@mistydemeo mistydemeo and 1 other commented on an outdated diff Apr 10, 2012

Library/Formula/openimageio.rb
- depends_on 'tbb' => :optional
+ # Help oiio find openjpeg includes.
+ oj = Formula.factory('openjpeg')
+ ENV.append 'MY_CMAKE_FLAGS', "-DOPENJPEG_INCLUDE_DIR=#{oj.include}/openjpeg-#{'%0.3s' % oj.version}"
@mistydemeo

mistydemeo Apr 10, 2012

Contributor

Is oiio compatible with more than one series of openjpeg? I assumed openjpeg versioned its include path due to incompatibilities.

@2bits

2bits Apr 10, 2012

Contributor

There are only 3 formulas that use openjpeg: oiio, mupdf, and gpac. All three use #include <openjpeg.h> with no version. I assumed that they knew how to craft the include, and it was my responsibility to locate it. At first I thought we were installing openjpeg incorrectly, but I can't justify that from looking at our formula. It just calls make install.

@mistydemeo

mistydemeo Apr 10, 2012

Contributor

Yeah, openjpeg is installing as standard. Perhaps the include paths were unversioned in the past, and they're written for that rather than 1.4 or 1.5? (Not sure how 1.4 handled include paths, but it wasn't mentioned in the 1.5 whatsnew, so...)

@2bits

2bits Apr 11, 2012

Contributor

Well I think I found the answer to the openjpeg.h mystery. I looked at it's source, and I found openjpeg can build with configure or cmake. We use cmake. So I switched to configure, and let it rip. Guess what? We get this:

$ ls -l /usr/local/Cellar/openjpeg/1.5.0/include
total 8
drwxr-xr-x  3 nibbles  admin  102 Apr 10 17:07 openjpeg-1.5
lrwxr-xr-x  1 nibbles  admin   23 Apr 10 17:07 openjpeg.h -> openjpeg-1.5/openjpeg.h

So I think we are building a crippled openjpeg by our choice of cmake (probably my fault lol).

@mistydemeo

mistydemeo Apr 11, 2012

Contributor

You mean we can avoid cmake? Two birds, one stone!

@mistydemeo mistydemeo and 1 other commented on an outdated diff Apr 10, 2012

Library/Formula/openimageio.rb
- depends_on 'tbb' => :optional
+ # Help oiio find openjpeg includes.
+ oj = Formula.factory('openjpeg')
+ ENV.append 'MY_CMAKE_FLAGS', "-DOPENJPEG_INCLUDE_DIR=#{oj.include}/openjpeg-#{'%0.3s' % oj.version}"
+ ENV.append 'MY_CMAKE_FLAGS', "-DOPENJPEG_LIBRARIES=#{oj.lib}"
@mistydemeo

mistydemeo Apr 10, 2012

Contributor

We should symlink against the openjpeg lib symlinks in the prefix, not openjpeg's location in the Cellar. Linking against the Cellar location will cause this to break if openjpeg is upgraded.

@mistydemeo

mistydemeo Apr 10, 2012

Contributor

Speaking of which - can oiio not detect this on its own?

@2bits

2bits Apr 10, 2012

Contributor

Ok I can try to use the one in #{HOMEBREW_PREFIX}/lib. I probably don't need to set it but did that not knowing what the problem was. I will correct that. Oiio can't detect openjpeg's include on its own because it uses a custom CMake module, FindOpenJpeg.cmake that looks here:

# Generic search paths
set (OpenJpeg_include_paths
     /usr/local/include/openjpeg
     /usr/local/include
     /usr/include/openjpeg
     /usr/include
     /opt/local/include)
Contributor

2bits commented Apr 11, 2012

I adjusted the oiio formula for the new openjpeg I referenced above, but I'll wait for that to get pulled before I commit.

Contributor

mistydemeo commented Apr 11, 2012

openjpeg has been pulled.

Contributor

2bits commented Apr 12, 2012

@mistydemeo I pretty sure the formula is now finalized from my pov. Commit 10e483b should be ok unless there are changes you'd like to see. That commit removes the build time dep on doxygen, as this already builds a pdf. Plus the html docs are on their website. So this saves duplicating them. I decided after sleeping on this to let it build the python bindings and iv as part of the regular build. This leaves only the --with-tests option. It makes it easier to install, easier to review, and it only takes 20sec or so extra to build everything. Mostly I felt this was acceptable because both Snow Leopard and Lion can pour Qt4 from a bottle. A normal install of oiio,

brew install oiio

would pour the bottles and get everything built. That simplifies any howto and leaves just the odd case of --with-tests to throw a wrench in the bottle pour.

I went ahead and tested stable, devel, and head with tests on Lion and 64bit Snow Leopard with XCode-4.0.2 there.
Head has a test failure in the png test. That is discussed upstream in this issue. Everything else works perfectly. So I didn't bother to make a rescue clause for the head test.

openimageio: Update to 1.0.3
Updates openimageio to version 1.0.3.
Fix compilation against glew.
Fix compilation against qt.
Fix building of iv.
Add all deps to maximize the filetypes oiio can open.
Add a dep on a new formula, field3d.
Add a dep on a new formula, opencolorio.
Build iv & the python bindings.
Run the official testsuite if the user options it.

This compiles without error using llvm-2335.9, clang-2.0.139,
and gcc-4.2.1.5666 from XCode-4.0.2 on 64bit Snow Leopard.
It compiles without error using llvm-2336.9 and clang-3.1.318
on Lion 10.7.3 using XCode-4.3.1.

As of 1.0.3 all tests pass make test.

EDIT: add an include for zlib.h on Lion.
EDIT: switches tarball to 0.10.4, compiles on Lion, same xfails
      in the testsuite (that only exists as a master on github).
EDIT: change the oiio-images url to a fixed commit tarball not
      the master trunk tarball.
EDIT: add def initialize to oiio-images subformula to trigger
      Homebrew's cache naming scheme, gets us oiioimages-1.0.0.tgz
EDIT: Change version to 0.10.5.  Remove patch for boost-mt naming
      because it works now.  Still needs zlib patch, been reported.
      Both previous test fails are fixed.  There is a new one.
EDIT: Inline the d variable.
EDIT: Remove HR, shorten option.
EDIT: Move inline patch to a DATA block.
EDIT: Change to version 0.10.6.
EDIT: Change to version 1.0.0.  Add devel block.
EDIT: Remove patch merged upstream.
EDIT: Fix python bindings to mimic vtk.rb.
EDIT: Add a dep on new formula OpenColorIO (ocio).
EDIT: Add a dep on webp.
EDIT: Remove illogical `which python-config` test.
EDIT: Add a fixed commit from branch RB-1.0 as the devel block url.
EDIT: Remove hard coded path to openjpeg.  Determine it instead.
EDIT: Upgrade to 1.0.2.  Shorten some comments.
EDIT: Remove code to find OpenJpeg.  It just works now.
EDIT: Add head url.  Remove Doxygen dep.  It already makes a pdf.
EDIT: Remove python option.  Just let it build that (10sec extra).
EDIT: Upgrade stable to 1.0.3, devel to 1.0.3a (bugfxes).
EDIT: Add back the oiio alias I clobbered.
Contributor

2bits commented Apr 19, 2012

@mistydemeo 4558db1 is rebased. It's a version update plus the oiio alias I clobbered. All tests now pass. Thanks!

@mistydemeo mistydemeo commented on the diff Apr 20, 2012

Library/Formula/openimageio.rb
homepage 'http://openimageio.org'
+ url 'https://github.com/OpenImageIO/oiio/tarball/Release-1.0.3'
+ sha1 '69919017a9fbc716d593eb508d04ea46626e96ed'
+
+ head 'https://github.com/OpenImageIO/oiio.git'
+
+ devel do
+ # This is the RB-1.0 development branch as of 18 APR 2012.
+ # The version number is artificial. Use it to name the cache tarball.
+ # Increment the letter when pointing to a more recent commit.
+ url 'https://github.com/OpenImageIO/oiio/tarball/dffc74eb53'
@mistydemeo

mistydemeo Apr 20, 2012

Contributor

Was this revision chosen arbitrarily, or does it represent a specific version that the oiio devs mean to be used? The purpose of devel is for specific development releases.

While I like pretty tarballs, I don't know I'm so comfortable making up version numbers.

Contributor

mistydemeo commented Apr 20, 2012

Pulled, minus the devel block.

Contributor

2bits commented Apr 20, 2012

Awesome, thanks for your help and for pulling this into the main repo. @lgritz made a helpful announcement when 1.0.0 was created explaining the stable tags, RB-1.0 devel branch, and head differences.

Contributor

mistydemeo commented Apr 20, 2012

I see the announcement, but it looks like they're announcing a branch - not a specific version, right? The purpose of devel is for explicit releases which are not part of a stable branch, for instance wine 1.4 vs wine 1.5.0, not for arbitrary commits from version control.

Contributor

2bits commented Apr 20, 2012

Yes indeed. No complaints at all.

lgritz commented Apr 20, 2012

Sorry, I assumed everybody knew the naming conventions. Branches are named RB-x.y, etc, tags are named Release-x.y.z. The latest tag in the preferred stable branch is Release-1.0.3, whereas RB-1.0 will give you whatever is at the top of the 1.0 tree at that moment (which is fairly stable as well, but not locked down forever like Release-x.y.z is). Does that clarify?

Contributor

2bits commented Apr 20, 2012

Perfectly clear. Your announcement confirmed that RB-1.0 was the tip of 1.0.3, just a few commits ahead normally. The devel block that @mistydemeo removed is something Homebrew uses to offer a vastly different, non-compatible branch that has it's own version numbers and releases. An example of that (not in the main repo yet) would be Avidemux that has a 2.5 branch and a 2.6 branch. The former operates on A/V entirely using frame numbers as reference, whereas 2.6 was rewritten from scratch to operate based on timecodes (giving accurate synch).

rohansingh added a commit to rohansingh/homebrew that referenced this pull request May 7, 2012

openimageio: Update to 1.0.3
Updates openimageio to version 1.0.3.
Fix compilation against glew.
Fix compilation against qt.
Fix building of iv.
Add all deps to maximize the filetypes oiio can open.
Add a dep on a new formula, field3d.
Add a dep on a new formula, opencolorio.
Build iv & the python bindings.
Run the official testsuite if the user options it.

This compiles without error using llvm-2335.9, clang-2.0.139,
and gcc-4.2.1.5666 from XCode-4.0.2 on 64bit Snow Leopard.
It compiles without error using llvm-2336.9 and clang-3.1.318
on Lion 10.7.3 using XCode-4.3.1.

As of 1.0.3 all tests pass make test.

EDIT: add an include for zlib.h on Lion.
EDIT: switches tarball to 0.10.4, compiles on Lion, same xfails
      in the testsuite (that only exists as a master on github).
EDIT: change the oiio-images url to a fixed commit tarball not
      the master trunk tarball.
EDIT: add def initialize to oiio-images subformula to trigger
      Homebrew's cache naming scheme, gets us oiioimages-1.0.0.tgz
EDIT: Change version to 0.10.5.  Remove patch for boost-mt naming
      because it works now.  Still needs zlib patch, been reported.
      Both previous test fails are fixed.  There is a new one.
EDIT: Inline the d variable.
EDIT: Remove HR, shorten option.
EDIT: Move inline patch to a DATA block.
EDIT: Change to version 0.10.6.
EDIT: Change to version 1.0.0.  Add devel block.
EDIT: Remove patch merged upstream.
EDIT: Fix python bindings to mimic vtk.rb.
EDIT: Add a dep on new formula OpenColorIO (ocio).
EDIT: Add a dep on webp.
EDIT: Remove illogical `which python-config` test.
EDIT: Add a fixed commit from branch RB-1.0 as the devel block url.
EDIT: Remove hard coded path to openjpeg.  Determine it instead.
EDIT: Upgrade to 1.0.2.  Shorten some comments.
EDIT: Remove code to find OpenJpeg.  It just works now.
EDIT: Add head url.  Remove Doxygen dep.  It already makes a pdf.
EDIT: Remove python option.  Just let it build that (10sec extra).
EDIT: Upgrade stable to 1.0.3, devel to 1.0.3a (bugfxes).
EDIT: Add back the oiio alias I clobbered.

Closes #8458.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

openimageio: Update to 1.0.3
Updates openimageio to version 1.0.3.
Fix compilation against glew.
Fix compilation against qt.
Fix building of iv.
Add all deps to maximize the filetypes oiio can open.
Add a dep on a new formula, field3d.
Add a dep on a new formula, opencolorio.
Build iv & the python bindings.
Run the official testsuite if the user options it.

This compiles without error using llvm-2335.9, clang-2.0.139,
and gcc-4.2.1.5666 from XCode-4.0.2 on 64bit Snow Leopard.
It compiles without error using llvm-2336.9 and clang-3.1.318
on Lion 10.7.3 using XCode-4.3.1.

As of 1.0.3 all tests pass make test.

EDIT: add an include for zlib.h on Lion.
EDIT: switches tarball to 0.10.4, compiles on Lion, same xfails
      in the testsuite (that only exists as a master on github).
EDIT: change the oiio-images url to a fixed commit tarball not
      the master trunk tarball.
EDIT: add def initialize to oiio-images subformula to trigger
      Homebrew's cache naming scheme, gets us oiioimages-1.0.0.tgz
EDIT: Change version to 0.10.5.  Remove patch for boost-mt naming
      because it works now.  Still needs zlib patch, been reported.
      Both previous test fails are fixed.  There is a new one.
EDIT: Inline the d variable.
EDIT: Remove HR, shorten option.
EDIT: Move inline patch to a DATA block.
EDIT: Change to version 0.10.6.
EDIT: Change to version 1.0.0.  Add devel block.
EDIT: Remove patch merged upstream.
EDIT: Fix python bindings to mimic vtk.rb.
EDIT: Add a dep on new formula OpenColorIO (ocio).
EDIT: Add a dep on webp.
EDIT: Remove illogical `which python-config` test.
EDIT: Add a fixed commit from branch RB-1.0 as the devel block url.
EDIT: Remove hard coded path to openjpeg.  Determine it instead.
EDIT: Upgrade to 1.0.2.  Shorten some comments.
EDIT: Remove code to find OpenJpeg.  It just works now.
EDIT: Add head url.  Remove Doxygen dep.  It already makes a pdf.
EDIT: Remove python option.  Just let it build that (10sec extra).
EDIT: Upgrade stable to 1.0.3, devel to 1.0.3a (bugfxes).
EDIT: Add back the oiio alias I clobbered.

Closes #8458.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

openimageio: Update to 1.0.3
Updates openimageio to version 1.0.3.
Fix compilation against glew.
Fix compilation against qt.
Fix building of iv.
Add all deps to maximize the filetypes oiio can open.
Add a dep on a new formula, field3d.
Add a dep on a new formula, opencolorio.
Build iv & the python bindings.
Run the official testsuite if the user options it.

This compiles without error using llvm-2335.9, clang-2.0.139,
and gcc-4.2.1.5666 from XCode-4.0.2 on 64bit Snow Leopard.
It compiles without error using llvm-2336.9 and clang-3.1.318
on Lion 10.7.3 using XCode-4.3.1.

As of 1.0.3 all tests pass make test.

EDIT: add an include for zlib.h on Lion.
EDIT: switches tarball to 0.10.4, compiles on Lion, same xfails
      in the testsuite (that only exists as a master on github).
EDIT: change the oiio-images url to a fixed commit tarball not
      the master trunk tarball.
EDIT: add def initialize to oiio-images subformula to trigger
      Homebrew's cache naming scheme, gets us oiioimages-1.0.0.tgz
EDIT: Change version to 0.10.5.  Remove patch for boost-mt naming
      because it works now.  Still needs zlib patch, been reported.
      Both previous test fails are fixed.  There is a new one.
EDIT: Inline the d variable.
EDIT: Remove HR, shorten option.
EDIT: Move inline patch to a DATA block.
EDIT: Change to version 0.10.6.
EDIT: Change to version 1.0.0.  Add devel block.
EDIT: Remove patch merged upstream.
EDIT: Fix python bindings to mimic vtk.rb.
EDIT: Add a dep on new formula OpenColorIO (ocio).
EDIT: Add a dep on webp.
EDIT: Remove illogical `which python-config` test.
EDIT: Add a fixed commit from branch RB-1.0 as the devel block url.
EDIT: Remove hard coded path to openjpeg.  Determine it instead.
EDIT: Upgrade to 1.0.2.  Shorten some comments.
EDIT: Remove code to find OpenJpeg.  It just works now.
EDIT: Add head url.  Remove Doxygen dep.  It already makes a pdf.
EDIT: Remove python option.  Just let it build that (10sec extra).
EDIT: Upgrade stable to 1.0.3, devel to 1.0.3a (bugfxes).
EDIT: Add back the oiio alias I clobbered.

Closes #8458.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.