This repository has been archived by the owner. It is now read-only.

Adding rudimentary hold support #9128

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@dreynolds
Contributor

dreynolds commented Dec 15, 2011

As the title says, I added some rudimentary hold support as Max mentioned here http://librelist.com/browser//homebrew/2011/2/10/how-do-you-hold-a-package/#70c01a17185156a819144fe006e9cd3d

Apologies for any bad Ruby that I may have written.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Dec 15, 2011

Contributor

Cool. Needs some review (and I don't have the time to do it, sorry).

Contributor

adamv commented Dec 15, 2011

Cool. Needs some review (and I don't have the time to do it, sorry).

@dreynolds

This comment has been minimized.

Show comment Hide comment
@dreynolds

dreynolds Dec 21, 2011

Contributor

Ugh, I didn't mean to do that

I fail at pull requests :(

Contributor

dreynolds commented Dec 21, 2011

Ugh, I didn't mean to do that

I fail at pull requests :(

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Mar 18, 2012

Contributor
Contributor

adamv commented Mar 18, 2012

+ ARGV.named.each do |name|
+ msg = blacklisted? name
+ raise "No available formula for #{name}\n#{msg}" if msg
+ end unless ARGV.force?

This comment has been minimized.

Show comment Hide comment
@mxcl

mxcl Mar 19, 2012

Member

No need for this chunk of code.

@mxcl

mxcl Mar 19, 2012

Member

No need for this chunk of code.

+ hold = HOMEBREW_REPOSITORY+'Library/Hold'
+ if not File.exists? hold
+ mkdir hold
+ end

This comment has been minimized.

Show comment Hide comment
@mxcl

mxcl Mar 19, 2012

Member

Can replace with simply:

(HOMEBREW_REPOSITORY+'Library/Hold').mkpath
@mxcl

mxcl Mar 19, 2012

Member

Can replace with simply:

(HOMEBREW_REPOSITORY+'Library/Hold').mkpath
@mxcl

This comment has been minimized.

Show comment Hide comment
@mxcl

mxcl Mar 19, 2012

Member

Seems great to me. Thanks for the work.

Sorry to @adamv that its abuse of Library again. But since we've started we should continue.

But for the mythical brew2 we could and probably should just stick an empty HOLD file in the rack directory.

Member

mxcl commented Mar 19, 2012

Seems great to me. Thanks for the work.

Sorry to @adamv that its abuse of Library again. But since we've started we should continue.

But for the mythical brew2 we could and probably should just stick an empty HOLD file in the rack directory.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Mar 19, 2012

Contributor

Willing to "give it up" until brew2

Contributor

adamv commented Mar 19, 2012

Willing to "give it up" until brew2

@mxcl

This comment has been minimized.

Show comment Hide comment
@mxcl

mxcl Mar 19, 2012

Member

Despite the fact I argued against it last time you bought it up. I think it's the better way to do it.

Member

mxcl commented Mar 19, 2012

Despite the fact I argued against it last time you bought it up. I think it's the better way to do it.

@MikeMcQuaid

This comment has been minimized.

Show comment Hide comment
@MikeMcQuaid

MikeMcQuaid Feb 1, 2013

Member

Closing. Will reopen when you update using the comments and rebase. Thanks!

Member

MikeMcQuaid commented Feb 1, 2013

Closing. Will reopen when you update using the comments and rebase. Thanks!

@MikeMcQuaid MikeMcQuaid closed this Feb 1, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.