This repository has been archived by the owner on Jan 27, 2020. It is now read-only.
Add option for advanced readline support to Lua #9228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua can be patched to provide better readline support.[1] On OSX the patch will use libedit. I am new to Lua, so I can't say how popular this patch is, but it builds cleanly and easily with Homebrew, and I'm already finding that it makes Lua's REPL much more friendly. [1] See http://lua-users.org/wiki/LuaPowerPatches, under 'Advanced readline support'.
| @@ -15,8 +15,14 @@ class Lua < Formula | |||
| # See: https://github.com/mxcl/homebrew/pull/5043 | |||
| def patches | |||
| DATA | |||
| if ARGV.include? '--completion' | |||
| 'http://luajit.org/patches/lua-5.1.4-advanced_readline.patch' | |||
| end | |||
There was a problem hiding this comment.
patches needs to return an array here; specifying '--completion' will skip the DATA patch.
There was a problem hiding this comment.
Ah, that's stupid of me. It's been a while since I dealt with patches. I'll close this pull request and resubmit. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Lua can be patched to provide better readline support.[1] On OSX the patch
will use libedit.
I am new to Lua, so I can't say how popular this patch is, but it builds
cleanly and easily with Homebrew, and I'm already finding that it makes
Lua's REPL much more friendly.
[1] See http://lua-users.org/wiki/LuaPowerPatches, under 'Advanced readline
support'.