This repository has been archived by the owner. It is now read-only.

New formula: trafficserver-3.0.2 (http://trafficserver.apache.org/) #9513

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@msabramo
Contributor

msabramo commented Jan 9, 2012

Squashed commits in #9453 into one commit.

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 22, 2012

Contributor

How does this look?

Contributor

msabramo commented Jan 22, 2012

How does this look?

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 23, 2012

Contributor

OK, incorporated some of the feedback. Hopefully, this is acceptable now.

Contributor

msabramo commented Jan 23, 2012

OK, incorporated some of the feedback. Hopefully, this is acceptable now.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid
Member

MikeMcQuaid commented Jan 24, 2012

Doesn't build for me: https://gist.github.com/1672065

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 25, 2012

Contributor

@MikeMcQuaid That's odd - it's not clear to me what's failing:

/usr/bin/llvm-g++ -DHAVE_CONFIG_H  -I. -I../../lib/ts  -I../../iocore/eventsystem -I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb -I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils -I../../iocore/dns -I../../lib/records -I../../proxy -I../../proxy/hdrs -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils -I/opt/local/include -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Ddarwin -I/System/Library/Frameworks/Tcl.framework/Versions/8.5/Headers -I/usr/local/include  -O3  -pipe -march=core2 -msse4 -g -Wall -Werror -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -MT SSLNet.o -MD -MP -MF .deps/SSLNet.Tpo -c -o SSLNet.o SSLNet.cc
mv -f .deps/NetConfig.Tpo .deps/NetConfig.Po
/usr/bin/llvm-g++ -DHAVE_CONFIG_H  -I. -I../../lib/ts  -I../../iocore/eventsystem -I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb -I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils -I../../iocore/dns -I../../lib/records -I../../proxy -I../../proxy/hdrs -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils -I/opt/local/include -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Ddarwin -I/System/Library/Frameworks/Tcl.framework/Versions/8.5/Headers -I/usr/local/include  -O3  -pipe -march=core2 -msse4 -g -Wall -Werror -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -MT SSLNetVConnection.o -MD -MP -MF .deps/SSLNetVConnection.Tpo -c -o SSLNetVConnection.o SSLNetVConnection.cc
mv -f .deps/Net.Tpo .deps/Net.Po
mv -f .deps/NetVConnection.Tpo .deps/NetVConnection.Po
mv -f .deps/SSLConfig.Tpo .deps/SSLConfig.Po
mv -f .deps/Connection.Tpo .deps/Connection.Po
mv -f .deps/Socks.Tpo .deps/Socks.Po
==> Exit Status: 2
http://github.com/mxcl/homebrew/blob/master/Library/Formula/trafficserver.rb#L13

It looks like a simple mv command failed?

  1. Do you have ample free disk space?
  2. What happens if you download the tarball manually from http://www.apache.org/dyn/closer.cgi/trafficserver/trafficserver-3.0.2.tar.bz2 and do ./configure and make?
Contributor

msabramo commented Jan 25, 2012

@MikeMcQuaid That's odd - it's not clear to me what's failing:

/usr/bin/llvm-g++ -DHAVE_CONFIG_H  -I. -I../../lib/ts  -I../../iocore/eventsystem -I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb -I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils -I../../iocore/dns -I../../lib/records -I../../proxy -I../../proxy/hdrs -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils -I/opt/local/include -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Ddarwin -I/System/Library/Frameworks/Tcl.framework/Versions/8.5/Headers -I/usr/local/include  -O3  -pipe -march=core2 -msse4 -g -Wall -Werror -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -MT SSLNet.o -MD -MP -MF .deps/SSLNet.Tpo -c -o SSLNet.o SSLNet.cc
mv -f .deps/NetConfig.Tpo .deps/NetConfig.Po
/usr/bin/llvm-g++ -DHAVE_CONFIG_H  -I. -I../../lib/ts  -I../../iocore/eventsystem -I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb -I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils -I../../iocore/dns -I../../lib/records -I../../proxy -I../../proxy/hdrs -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils -I/opt/local/include -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_GNU_SOURCE -D_REENTRANT -Ddarwin -I/System/Library/Frameworks/Tcl.framework/Versions/8.5/Headers -I/usr/local/include  -O3  -pipe -march=core2 -msse4 -g -Wall -Werror -feliminate-unused-debug-symbols -fno-strict-aliasing -Wno-invalid-offsetof -MT SSLNetVConnection.o -MD -MP -MF .deps/SSLNetVConnection.Tpo -c -o SSLNetVConnection.o SSLNetVConnection.cc
mv -f .deps/Net.Tpo .deps/Net.Po
mv -f .deps/NetVConnection.Tpo .deps/NetVConnection.Po
mv -f .deps/SSLConfig.Tpo .deps/SSLConfig.Po
mv -f .deps/Connection.Tpo .deps/Connection.Po
mv -f .deps/Socks.Tpo .deps/Socks.Po
==> Exit Status: 2
http://github.com/mxcl/homebrew/blob/master/Library/Formula/trafficserver.rb#L13

It looks like a simple mv command failed?

  1. Do you have ample free disk space?
  2. What happens if you download the tarball manually from http://www.apache.org/dyn/closer.cgi/trafficserver/trafficserver-3.0.2.tar.bz2 and do ./configure and make?
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Jan 25, 2012

Member

52G free. Will try that later.

Member

MikeMcQuaid commented Jan 25, 2012

52G free. Will try that later.

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 25, 2012

Contributor

Hmmm, this is a total hail mary, but you can try doing df -i to make sure you have inodes free. I'd bet that you do though.

That's just so weird that the last thing shown before "Exit Status: 2" was a mv command. I wonder if brew is not showing all of the output. I assume that you installed with brew install -vd trafficserver? Could also try doing the mv manually or doing make manually after brew install -vd trafficserver fails...

Contributor

msabramo commented Jan 25, 2012

Hmmm, this is a total hail mary, but you can try doing df -i to make sure you have inodes free. I'd bet that you do though.

That's just so weird that the last thing shown before "Exit Status: 2" was a mv command. I wonder if brew is not showing all of the output. I assume that you installed with brew install -vd trafficserver? Could also try doing the mv manually or doing make manually after brew install -vd trafficserver fails...

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 25, 2012

Contributor

Note: Traffic Server 3.1.2 should be able to build with warnings turned off. When that is released, we can consider removing the ENV.enable_warnings from the formula.

See: https://issues.apache.org/jira/browse/TS-1091

Contributor

msabramo commented Jan 25, 2012

Note: Traffic Server 3.1.2 should be able to build with warnings turned off. When that is released, we can consider removing the ENV.enable_warnings from the formula.

See: https://issues.apache.org/jira/browse/TS-1091

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 25, 2012

Owner

We must enable warnings; otherwise the configure script will wrongly guess that the style of gethostbyname_r is glibc and the build will fail. This should be fixed in Traffic Server 3.1.2 -- see https://issues.apache.org/jira/browse/TS-1091

We must enable warnings; otherwise the configure script will wrongly guess that the style of gethostbyname_r is glibc and the build will fail. This should be fixed in Traffic Server 3.1.2 -- see https://issues.apache.org/jira/browse/TS-1091

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 25, 2012

Owner

The --with-user and --with-group parameters to ./configure are required because otherwise the Traffic Server Makefile will try to install stuff as user nobody and group nobody in /usr/local, which fails.

The --with-user and --with-group parameters to ./configure are required because otherwise the Traffic Server Makefile will try to install stuff as user nobody and group nobody in /usr/local, which fails.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Jan 28, 2012

Member

https://gist.github.com/1693841 is a better gist as I remembered to redirect stderr.

The problem is enabling warnings combined with "cc1plus: warnings being treated as errors" (line 462).

Member

MikeMcQuaid commented Jan 28, 2012

https://gist.github.com/1693841 is a better gist as I remembered to redirect stderr.

The problem is enabling warnings combined with "cc1plus: warnings being treated as errors" (line 462).

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 29, 2012

Contributor

Ah. You must have Lion (I have 10.6.8). We have Apple to thank for this one -- they've deprecated OpenSSL in Lion in favor of using their own library called Common Crypto:

http://ludovicrousseau.blogspot.com/2011/08/mac-os-x-lion-and-openssl.html

Two things to try:

  • brew install openssl -- hopefully Traffic Server's configure script will pick up the homebrewed OpenSSL, though you'll probably have to tweak your build variables:
LDFLAGS  -L/usr/local/Cellar/openssl/0.9.8r/lib
CPPFLAGS -I/usr/local/Cellar/openssl/0.9.8r/include
  • Modify the formula so it adds -Wno-deprecated-declarations to CFLAGS.

Good luck!

Contributor

msabramo commented Jan 29, 2012

Ah. You must have Lion (I have 10.6.8). We have Apple to thank for this one -- they've deprecated OpenSSL in Lion in favor of using their own library called Common Crypto:

http://ludovicrousseau.blogspot.com/2011/08/mac-os-x-lion-and-openssl.html

Two things to try:

  • brew install openssl -- hopefully Traffic Server's configure script will pick up the homebrewed OpenSSL, though you'll probably have to tweak your build variables:
LDFLAGS  -L/usr/local/Cellar/openssl/0.9.8r/lib
CPPFLAGS -I/usr/local/Cellar/openssl/0.9.8r/include
  • Modify the formula so it adds -Wno-deprecated-declarations to CFLAGS.

Good luck!

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Jan 29, 2012

Member

We can't rely on a brew install'd openssl I'm afraid. If you modify the formulae I'm happy to test the changes. Thanks!

Member

MikeMcQuaid commented Jan 29, 2012

We can't rely on a brew install'd openssl I'm afraid. If you modify the formulae I'm happy to test the changes. Thanks!

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 29, 2012

Contributor

Can you give this a try please?:

This just ignores the OpenSSL deprecation by adding -Wno-deprecated-declarations to CFLAGS and CXXFLAGS.

Contributor

msabramo commented Jan 29, 2012

Can you give this a try please?:

This just ignores the OpenSSL deprecation by adding -Wno-deprecated-declarations to CFLAGS and CXXFLAGS.

@msabramo msabramo closed this Jan 29, 2012

@msabramo msabramo reopened this Jan 29, 2012

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Jan 29, 2012

Member

Works great, merged.

Member

MikeMcQuaid commented Jan 29, 2012

Works great, merged.

@msabramo

This comment has been minimized.

Show comment
Hide comment
@msabramo

msabramo Jan 29, 2012

Contributor

I've tried, unsuccessfully so far, to have it depends_on openssl and use the brewed OpenSSL, as Traffic Server is trying to build as x86_64 and the OpenSSL lib that brew installed seems to be i386 and they won't link. Forcing Traffic Server to build as i386 didn't work as that caused it to not be able to link with pcre. Seems like a can of worms. Perhaps this is what you were alluding to when you said we can't rely on a brew install'd openssl?

It seems that this is a general problem that will have to be solved in Homebrew as Lion deprecated OpenSSL and lots of formulas probably depend on it.

Contributor

msabramo commented Jan 29, 2012

I've tried, unsuccessfully so far, to have it depends_on openssl and use the brewed OpenSSL, as Traffic Server is trying to build as x86_64 and the OpenSSL lib that brew installed seems to be i386 and they won't link. Forcing Traffic Server to build as i386 didn't work as that caused it to not be able to link with pcre. Seems like a can of worms. Perhaps this is what you were alluding to when you said we can't rely on a brew install'd openssl?

It seems that this is a general problem that will have to be solved in Homebrew as Lion deprecated OpenSSL and lots of formulas probably depend on it.

@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Jan 29, 2012

Member

We shouldn't depend on the Homebrew OpenSSL. This won't be a problem until we hit 10.8.

Member

MikeMcQuaid commented Jan 29, 2012

We shouldn't depend on the Homebrew OpenSSL. This won't be a problem until we hit 10.8.

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

New formula: trafficserver-3.0.2 (http://trafficserver.apache.org/)
Closes #9513.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

New formula: trafficserver-3.0.2 (http://trafficserver.apache.org/)
Closes #9513.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.