Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Xcode 4.2 fixes #9622

Closed
wants to merge 2 commits into from
Closed

Xcode 4.2 fixes #9622

wants to merge 2 commits into from

Conversation

MikeMcQuaid
Copy link
Member

Use Clang on fails_with_llvm and bump the highest seen LLVM version to that from Xcode 4.2.

Again I'm wondering if we should set Clang to the default compiler on Xcode 4.2 or keep using the /usr/bin/{cc,c++} symlinks to decide.

@jacknagel
Copy link
Contributor

I think this is fine, but we should keep trying to respect /usr/bin/cc when possible.

It's hard to say "this version of OS X with this version of XCode should use ____" because there are corner cases. For example, I'm on Snow Leopard, using XCode 4.2, and I have both gcc 4.0 and 4.2 left over from previous XCode installs. And some Lion users who upgraded XCode still have gcc 4.2 around.

I'm trying to address this in my work to make fails_with more generic by avoiding checking the OS X/XCode versions unless absolutely necessary and relying almost entirely on compiler build numbers instead; I'll try to have something reviewable this week.

@MikeMcQuaid
Copy link
Member Author

Ok. Will merge this as-is. Thanks.

@jacknagel
Copy link
Contributor

And I agree that in general, we should be encouraging clang for users with the most up-to-date tools.

@MikeMcQuaid
Copy link
Member Author

Cool, glad we're agreed. Will leave it as-is until you've got something to look at. Ping me then.

etehtsea pushed a commit to etehtsea/homebrew that referenced this pull request Jan 16, 2012
Closes Homebrew#9622.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Jun 18, 2012
Closes Homebrew#9622.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
Closes Homebrew#9622.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants