This repository has been archived by the owner. It is now read-only.

Rename and upgdate sphinxbase and pocketsphinx #9904

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

dickoff commented Jan 31, 2012

Formerly cmu-sphinxbase and cmu-pocketsphinx, I dropped the cmu- from the name because the official library name doesn't have the cmu. I also updated the version to 0.7 in the process.

Contributor

jacknagel commented Jan 31, 2012

The thing about renames is that they break compatibility in parts of the code that look at existing kegs using the "canonical" name. Can we just add aliases instead?

Contributor

dickoff commented Jan 31, 2012

Do you mean alias cmu-sphinxbase to sphinxbase or vice versa?

Contributor

jacknagel commented Jan 31, 2012

Preserve the current filenames, add aliases for the correct names.

In the long run it would be better to teach the relevant code to "just work" as long as the keg's name resolves to a formula, whether it is an alias or not; for the time being, though we have to avoid renames.

Contributor

dickoff commented Feb 2, 2012

hmm, added the alias and moved the files again, but it seems that some merges were put in this too... @jacknagel help on what to do with those? My git fu isn't that good.

Contributor

jacknagel commented Feb 2, 2012

Don't worry, I can clean it up. Though as a general rule, using a branch besides master helps keep these things tidy.

Contributor

dickoff commented Feb 2, 2012

Makes sense, thanks.

@jacknagel jacknagel closed this in 519d937 Feb 2, 2012

@sorin-ionescu sorin-ionescu added a commit to sorin-ionescu/legacy-homebrew that referenced this pull request Feb 13, 2012

@dickoff @sorin-ionescu dickoff + sorin-ionescu Add aliases for pocketsphinx and sphinxbase
Closes #9904.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
77ceb9f

@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

@dickoff @jacknagel dickoff + jacknagel Add aliases for pocketsphinx and sphinxbase
Closes #9904.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
3bfff9a

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.