Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botan: Fix build for Linux #18695

Closed
wants to merge 1 commit into from
Closed

botan: Fix build for Linux #18695

wants to merge 1 commit into from

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 7, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • Have you included the output of brew gist-logs <formula> of the build failure if your PR fixes a build failure. Please quote the exact error message.

  • Work in progress...

  • Will eventually fix #18694. (Gist logs are in that issue.)

  • This was failing with:

NoMethodError: undefined method `preferred_arch' for OS::Mac:Module
  • And it needed some more Linux tweaks.
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 7, 2020

==> ./configure.py --prefix=/home/linuxbrew/.linuxbrew/Cellar/botan/2.12.1 --docdir=share/doc --cpu=x86_64 --cc=gcc-5 --os=linux --with-openssl --with-zlib --with-bzip2
/usr/bin/env: ‘python’: No such file or directory

:eyebrows: This is not the error I got locally, so that's progress, I suppose.

@dawidd6 dawidd6 force-pushed the issyl0:botan-fix-build branch 2 times, most recently from 0cb9b4d to f135bf8 Jan 8, 2020
- This was failing with:

```
NoMethodError: undefined method `preferred_arch' for OS::Mac:Module
```

- And it needed some more Linux tweaks.
@dawidd6 dawidd6 force-pushed the issyl0:botan-fix-build branch from f135bf8 to 385c28e Jan 8, 2020
@dawidd6 dawidd6 marked this pull request as ready for review Jan 8, 2020
@dawidd6 dawidd6 added the bottle label Jan 8, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 8, 2020

Thanks for picking this up, @dawidd6! I'll pull this when I'm home.

@issyl0 issyl0 closed this in f503f01 Jan 8, 2020
@issyl0 issyl0 deleted the issyl0:botan-fix-build branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.