Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2020-01-12 69870da91d4 #18920

Merged
merged 5 commits into from Jan 12, 2020
Merged

Conversation

@issyl0
Copy link
Member

issyl0 commented Jan 12, 2020

Merge Homebrew/homebrew-core into Homebrew/linuxbrew-core

  • aws-elasticbeanstalk
issyl0 and others added 5 commits Jan 12, 2020
…ed` (#48929)

- I forgot that GitHub doesn't support secrets in Actions from forked repos, [until there was a legitimate use case for adding a label](Homebrew/homebrew-core#48927), so the action will fail:

```
/opt/hostedtoolcache/Ruby/2.6.3/x64/lib/ruby/gems/2.6.0/gems/octokit-4.15.0/lib/octokit/response/raise_error.rb:16:in `on_complete': POST https://api.github.com/repos/Homebrew/homebrew-core/issues/48927/labels: 403 - Resource not accessible by integration // See: https://developer.github.com/v3/issues/labels/#add-labels-to-an-issue (Octokit::Forbidden)
```

- Given our PR workflow is "forked repo for everything", we can't do this until
  GitHub supports using secrets in forked PRs. It's a [requested
  feature](https://github.community/t5/GitHub-Actions/how-to-use-GITHUB-TOKEN-for-PRs-from-forks/td-p/37450).
- Maybe at some other point in the future, we can revisit this and other
  auto-labelling actions.
- I enjoyed making it nonetheless, and now I have "forked repos" to add to my
  testing for future Actions proof-of-concepts!

----

Reverts #48911 and supersedes #48919.
Closes #48923.

Signed-off-by: Issy Long <me@issyl0.co.uk>
 Conflicts:
	Formula/aws-elasticbeanstalk.rb
@issyl0 issyl0 self-assigned this Jan 12, 2020
@issyl0 issyl0 added the merge label Jan 12, 2020
@issyl0 issyl0 merged commit 1db1668 into Homebrew:master Jan 12, 2020
1 check failed
1 check failed
linuxbrew-core Build #20200112.36 failed
Details
@issyl0 issyl0 deleted the issyl0:merge-2020-01-12-69870da91d4 branch Jan 12, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Jan 12, 2020

Did such a slim merge to get rid of the bugged GitHub Action from here. 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.