Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/strip: delete #19435

Merged
merged 1 commit into from Feb 2, 2020
Merged

cmd/strip: delete #19435

merged 1 commit into from Feb 2, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 2, 2020

  • It doesn't work due to undefined method 'resolved_formulae' because
    of the recent Homebrew.args changes.
  • It was added in #4420
    (2017), but according to @sjackman in person just now it's not needed
    any more: "yeah, that can go away."
- It doesn't work due to `undefined method 'resolved_formulae'` because
  of the recent `Homebrew.args` changes.
- It was added in #4420
  (2017), but according to @sjackman in person just now it's not needed
  any more: "yeah, that can go away."
@issyl0 issyl0 merged commit 69aa609 into Homebrew:master Feb 2, 2020
1 check failed
1 check failed
build-bottles build-bottles
Details
@issyl0 issyl0 deleted the issyl0:rm-brew-strip-cmd branch Feb 2, 2020
@jonchang

This comment has been minimized.

Copy link
Member

jonchang commented Feb 2, 2020

N.B. This was needed during the early days when Linuxbrew built bottles with standard env rather than superenv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.