Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actions] Re-instate `brew test-bot` CI checks on PRs (without bottles) #19463

Closed
wants to merge 3 commits into from

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 4, 2020

When we fix broken builds, we want to push our fixes to CI and let them run - if it's a long-running or particularly CPU-intensive build, we don't want to always melt our computers rebuilding and rebuilding formulae when GitHub gives us lots of power and time.

issyl0 added 2 commits Feb 4, 2020
- We still need to be able to have `brew test-bot` run on PRs, for when
  we fix failing builds. This reduces the load on our local machines,
  which may be less powerful than CI and where build-times increase a
  lot.
- I have not yet tested this. We'll see.
Co-Authored-By: Jonathan Chang <jchang641@gmail.com>
@jonchang

This comment has been minimized.

Copy link
Member

jonchang commented Feb 4, 2020

Hold off on this for now, we can reuse this code for fork-merge workflows.

@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 4, 2020

Superseded by @jonchang's million workflow commits to master.

@issyl0 issyl0 closed this Feb 4, 2020
@issyl0 issyl0 deleted the issyl0:workflow-name-change branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.