Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `BrewTestBot` user in all Actions for git operations #19504

Merged
merged 1 commit into from Feb 5, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 5, 2020

  • We now push commits as the BrewTestBot user, not the
    LinuxbrewTestBot user - so I think it makes sense to adjust the Git
    config in the brew test-bot-related actions.
@dawidd6

This comment has been minimized.

Copy link
Member

dawidd6 commented Feb 5, 2020

- We now push commits as the `BrewTestBot` user, not the
  `LinuxbrewTestBot` user - so I think it makes sense to adjust the Git
  config in the `brew test-bot`-related actions.
- We can remove the `--git-name` and `--git-email` `brew test-bot` flag
  settings as BrewTestBot is [the
  default](https://github.com/Homebrew/homebrew-test-bot/blob/1eb16f5970e1ec3f6a32e78cc4a935abdd3a5b7c/lib/test_bot.rb#L332).
@issyl0 issyl0 force-pushed the issyl0:update-actions-to-use-brewtestbot branch from a83c90a to 61cdbe1 Feb 5, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 5, 2020

Deleting lines is what I like.

@issyl0 issyl0 merged commit 90ccdc6 into Homebrew:master Feb 5, 2020
@issyl0 issyl0 deleted the issyl0:update-actions-to-use-brewtestbot branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.