Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aamath: Fix build for Linux #19520

Merged
merged 1 commit into from Feb 6, 2020
Merged

aamath: Fix build for Linux #19520

merged 1 commit into from Feb 6, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 6, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • Have you included the output of brew gist-logs <formula> of the build failure if your PR fixes a build failure. Please quote the exact error message.

Gist logs: https://gist.github.com/f35fbd08bfda962a28be9668dcc5a340

@sjackman

This comment has been minimized.

Copy link
Member

sjackman commented Feb 6, 2020

g++ -Wall -O2 -g -DUSE_READLINE -c aamath.cc
722
aamath.cc:19:31: fatal error: readline/readline.h: No such file or directory
723

https://github.com/Homebrew/linuxbrew-core/pull/19520/checks?check_run_id=430766528#step:5:722

@@ -15,6 +15,11 @@ class Aamath < Formula
sha256 "0212e0b5844ea1a491bc7d4fcab2b590921042b28bc50e79c36cd9e15d08e2aa" => :mavericks
end

unless OS.mac?
depends_on "bison" => :build # for yacc
depends_on "flex" => :build

This comment has been minimized.

Copy link
@sjackman

sjackman Feb 6, 2020

Member
Suggested change
depends_on "flex" => :build
uses_from_macos "flex" => :build

Does uses_from_macos "…" => :build work?

This comment has been minimized.

Copy link
@issyl0

issyl0 Feb 6, 2020

Author Member

It does! I'm never sure which dependencies are macOS-provided until I have time to search Homebrew/homebrew-core for the uses_from_macos equivalent.

@issyl0 issyl0 force-pushed the issyl0:aamath-fix-build branch from 4b8da8f to df9e9c7 Feb 6, 2020
@issyl0

This comment has been minimized.

Copy link
Member Author

issyl0 commented Feb 6, 2020

==> brew linkage --test aamath
Missing libraries:
  libreadline.so.8
==> FAILED

What more does it want from me?! Ah, :build was wrong.

@issyl0 issyl0 force-pushed the issyl0:aamath-fix-build branch from df9e9c7 to 5125e39 Feb 6, 2020
@issyl0 issyl0 merged commit 33f09a3 into Homebrew:master Feb 6, 2020
1 check passed
1 check passed
build-bottles
Details
@issyl0 issyl0 deleted the issyl0:aamath-fix-build branch Feb 6, 2020
@issyl0 issyl0 mentioned this pull request Feb 6, 2020
2 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.