Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: create issue comment when CI fails #19531

Open
wants to merge 1 commit into
base: master
from

Conversation

@dawidd6
Copy link
Member

dawidd6 commented Feb 7, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • Have you included the output of brew gist-logs <formula> of the build failure if your PR fixes a build failure. Please quote the exact error message.

@dawidd6

This comment has been minimized.

Copy link
Member Author

dawidd6 commented Feb 7, 2020

This is just a sketch currently.

uses: peter-evans/create-or-update-comment@v1
with:
token: ${{secrets.HOMEBREW_GITHUB_API_TOKEN}}
issue-number: 1 # TODO

This comment has been minimized.

Copy link
@issyl0

issyl0 Feb 7, 2020

Member

So the plan is to create a (giant) tracking issue with a comment for every failing build? 👍

This comment has been minimized.

Copy link
@dawidd6

dawidd6 Feb 7, 2020

Author Member

Any other ideas?

This comment has been minimized.

Copy link
@iMichka

iMichka Feb 7, 2020

Member

Open a PR each time? Maybe we need to add build-bottle-pr back ...

This comment has been minimized.

Copy link
@iMichka

iMichka Feb 7, 2020

Member

My rationale is that you can then checkout the PR right away and start hacking around.

This comment has been minimized.

Copy link
@issyl0

issyl0 Feb 7, 2020

Member

Push an empty commit to the newly opened PR instead of # Build a bottle for Linux, then we don't have to also bring back squash-bottle-pr and have to remember two sets of workflows? 😂

This comment has been minimized.

Copy link
@iMichka

iMichka Feb 7, 2020

Member

I am fine with an empty commit.
We should set the title to be the bottle name (if possible), and maybe put the log content in the issue text? I think this can be done through the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.