Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmsx: Fix build for Linux with XOrg dependency #19541

Merged
merged 1 commit into from Feb 9, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 9, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • Have you included the output of brew gist-logs <formula> of the build failure if your PR fixes a build failure. Please quote the exact error message.

https://github.com/Homebrew/linuxbrew-core/runs/434270743?check_suite_focus=true

2020-02-09T06:41:42.0796137Z X11 is required to install this formula,
either Xorg 1.12.2 or xdpyinfo 1.3.0, or newer. X11Requirement
unsatisfied!
2020-02-09T06:41:42.0796798Z You can install with Homebrew Cask:
2020-02-09T06:41:42.0797258Z   brew cask install xquartz

I was wondering if it's worth the effort to make the brew Requirements
error add Linux instructions. Probably not if Linuxbrew/homebrew-xorg is
merging with Homebrew/homebrew-core and hopefully things won't depend on
Casks for much longer!

https://github.com/Homebrew/linuxbrew-core/runs/434270743?check_suite_focus=true

```
2020-02-09T06:41:42.0796137Z X11 is required to install this formula,
either Xorg 1.12.2 or xdpyinfo 1.3.0, or newer. X11Requirement
unsatisfied!
2020-02-09T06:41:42.0796798Z You can install with Homebrew Cask:
2020-02-09T06:41:42.0797258Z   brew cask install xquartz
```
@issyl0 issyl0 merged commit 0407881 into Homebrew:master Feb 9, 2020
1 check passed
1 check passed
build-bottles
Details
@issyl0 issyl0 deleted the issyl0:fmsx-fix-build branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.