Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobby: Fix build for Linux #19545

Merged
merged 2 commits into from Feb 9, 2020
Merged

gobby: Fix build for Linux #19545

merged 2 commits into from Feb 9, 2020

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 9, 2020


This is a manual PR. I'm going through the recent build failures of
mass-bottling attempts and raising PRs with empty commits and the
log of the build failure, so we can target fixes.


From
https://github.com/Homebrew/linuxbrew-core/runs/434444958?check_suite_focus=true:

checking for perl >= 5.8.1... 5.22.1
checking for XML::Parser... configure: error: XML::Parser perl module is
required for intltool
@issyl0 issyl0 self-assigned this Feb 9, 2020
From
https://github.com/Homebrew/linuxbrew-core/runs/434444958?check_suite_focus=true:

```
checking for perl >= 5.8.1... 5.22.1
checking for XML::Parser... configure: error: XML::Parser perl module is
required for intltool
```
@issyl0 issyl0 force-pushed the issyl0:gobby-build-failure branch from a3f2f1b to 34e296d Feb 9, 2020
@issyl0 issyl0 changed the title gobby gobby: Fix build for Linux Feb 9, 2020
system "./configure", "--disable-dependency-tracking",
"--prefix=#{prefix}", "--with-gtk3"
system "make", "install"
end

test do
return if !OS.mac? && ENV["CI"]

This comment has been minimized.

Copy link
@dawidd6

dawidd6 Feb 9, 2020

Member

Need an empty line after return statement

```
==> brew test gobby --verbose
Testing gobby
==> /home/linuxbrew/.linuxbrew/Cellar/gobby/0.5.0_7/bin/gobby-0.5
--version
Cannot open display:
Error: gobby: failed
```
@issyl0 issyl0 force-pushed the issyl0:gobby-build-failure branch from 1458714 to 523f38e Feb 9, 2020
@dawidd6 dawidd6 merged commit a6f9c83 into Homebrew:master Feb 9, 2020
1 check passed
1 check passed
build-bottles
Details
@issyl0 issyl0 deleted the issyl0:gobby-build-failure branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.