Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: use python@3.8 #19619

Merged
merged 1 commit into from Feb 13, 2020
Merged

rust: use python@3.8 #19619

merged 1 commit into from Feb 13, 2020

Conversation

@dawidd6
Copy link
Member

dawidd6 commented Feb 13, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?
  • Have you included the output of brew gist-logs <formula> of the build failure if your PR fixes a build failure. Please quote the exact error message.

@dawidd6 dawidd6 self-assigned this Feb 13, 2020
@dawidd6

This comment has been minimized.

Copy link
Member Author

dawidd6 commented Feb 13, 2020

Build starship if this get merged.

@dawidd6 dawidd6 force-pushed the dawidd6:rust branch from 9636862 to 8de75ed Feb 13, 2020
@dawidd6 dawidd6 added the python label Feb 13, 2020
@dawidd6 dawidd6 requested a review from iMichka Feb 13, 2020
@issyl0
issyl0 approved these changes Feb 13, 2020
Copy link
Member

issyl0 left a comment

Great work! My faith in Rust 🦀is restored!

if OS.mac?
uses_from_macos "python@2"
else
depends_on "python@3.8"

This comment has been minimized.

Copy link
@issyl0

issyl0 Feb 13, 2020

Member

At a later date, is there a plan to convert this to use Python 3 upstream as well? That feels like a nice thing to do.

This comment has been minimized.

Copy link
@dawidd6

dawidd6 Feb 13, 2020

Author Member

Yes, I think so.

This comment has been minimized.

Copy link
@iMichka

iMichka Feb 13, 2020

Member

Yes. I debug stuff in linuxbrew first, as it is easier to see if python 2 is being picked up. I then backport the change to macOS.

@iMichka iMichka merged commit 18a7a4a into Homebrew:master Feb 13, 2020
1 check passed
1 check passed
build-bottles
Details
@dawidd6 dawidd6 deleted the dawidd6:rust branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.