Custom fields validation fix #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation is performed by checking that a field element doesn't use more bits than declared during sidechain creation. The function performing such validation was handling bits with wrong endianness.
i-Alex
reviewed
Dec 30, 2021
This has been done to increase compatibility and avoid using a built-in function available only on specific architecture.
alsala
approved these changes
Jan 12, 2022
VolodymyrBabaiev
approved these changes
Jan 12, 2022
i-Alex
approved these changes
Jan 13, 2022
Also added a comment to explain the reason behind the implementation of the TestRandomCustomFieldGeneration unit test.
alsala
reviewed
Jan 13, 2022
Also added a check to TestGetBytesFromBits for negative values.
alsala
approved these changes
Jan 14, 2022
albertog78
approved these changes
Feb 16, 2022
cronicc
added a commit
that referenced
this pull request
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for the custom fields management. In particular, the validation function was using the wrong bit endianness to check custom fields against the configuration (bit length) specified during sidechain creation.