Skip to content

Remove unnecessary lifetime annotations. #176

Merged
merged 1 commit into from Jul 21, 2014

3 participants

@utkarshkukreti

A patch to make this possible just landed in Rust master a few hours ago.

@aochagavia
Collaborator

Are these errors legit or caused by using an older version of rustc? I have tried some code in the playpen but got the same errors as Travis.

@pfalabella
Collaborator

it seems like Travis lags a bit behind current nightlies. I tried compiling one of the changed files locally and it works. Nightlies version for reference (on windows 7):

 $ rustc --version
rustc 0.12.0-pre-nightly (f15d6d28396e8700b6c3f2704204a2769e710403 2014-07-20 22:46:29 +0000) 

lifetime elision issue for reference is rust-lang/rust#15767.

@utkarshkukreti utkarshkukreti Remove unnecessary lifetime annotations.
A patch to make this possible just landed in Rust master a few hours
ago.
726d78c
@utkarshkukreti

@pfalabella is right. It's passing now on Travis.

@pfalabella
Collaborator

by the way... if I try running the 9_billion_names_of_God_the_integer.exe, it crashes on windows when trying to calculate the last sum.
I have never tried running it before, so it might be an issue I've always had but never noticed... Could you please try running it on your machine?

rows
1: 1,
2: 1, 1,
3: 1, 1, 1,
4: 1, 2, 1, 1,
5: 1, 2, 2, 1, 1,
6: 1, 3, 3, 2, 1, 1,
7: 1, 3, 4, 3, 2, 1, 1,
8: 1, 4, 5, 5, 3, 2, 1, 1,
9: 1, 4, 7, 6, 5, 3, 2, 1, 1,
10: 1, 5, 8, 9, 7, 5, 3, 2, 1, 1,
sums
23: 1255
123: 2552338241
1234: 156978797223733228787865722354959930

Program received signal SIGILL, Illegal instruction.
0x004fba70 in oom::hea464ba6c9767073pPa ()
@aochagavia
Collaborator

Awesome! Thanks!

@aochagavia aochagavia merged commit 5eaa79a into Hoverbear:master Jul 21, 2014

1 check passed

Details continuous-integration/travis-ci The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.