Add edit button to Navbar #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the control to the top-right of the nav window to enable and disable `allowEdit` state. This PR will also contain the collapse functionality for the navbar.
Make the nav bar collapsible the same way as on the existing application. That way you can expand the navbar to see all the links on your phone, if you have a driving need to do so.
ssalinas
reviewed
Feb 17, 2017
| @@ -291,6 +292,22 @@ export default class FormModal extends React.Component { | |||
| </FormModal.FormItem> | |||
| ); | |||
|
|
|||
| case FormModal.INPUT_TYPES.PASSWORD: | |||
There was a problem hiding this comment.
might be easier to add a parameter that can be passed to the STRING input type, or in some way reusing that code since this is the same save for the type="password" line
Formerly the code for the password input field was entirely duplicated from the code for the password and duration fields. This refactors that slightly so the input type can be configured in the same way, but it only uses the code for it once.
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the edit button to the navbar. This behaves the same way as the existing system; it brings up a modal that prompts for the auth key and if successful, will store both the auth key and the 'can-edit' state in local storage /
window.config.