Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always call applyCurrentConfigs in checkStateNodeVersion #233

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
1 participant
@ssalinas
Copy link
Member

commented Oct 2, 2017

I realized while debugging something separate that this was not getting called correctly. The state node version check and setting is done inside applyCurrentConfigs, so setting it afterwards is not needed. Also, in the case where exitOnStartupError is false, it gives us the opportunity to retry any applies that may have failed during the initial apply.

@ssalinas ssalinas merged commit 66eb7d9 into master Oct 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the startup_fix branch Oct 3, 2017

@ssalinas ssalinas added this to the 0.6.0 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.