state getter fix + make user groups immutable set

HubSpot · Jul 17, 2015 · 4933b81 · 4933b81
1 parent cdfc22b
commit 4933b81
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/SingularityBase/src/main/java/com/hubspot/singularity/SingularityState.java b/SingularityBase/src/main/java/com/hubspot/singularity/SingularityState.java
@@ -221,7 +221,7 @@ public int getUnknownRacks() {
     return unknownRacks;
   }
 
-  public Optional<Boolean> isAuthDatastoreHealthy() {
+  public Optional<Boolean> getAuthDatastoreHealthy() {
     return authDatastoreHealthy;
   }
 

diff --git a/SingularityBase/src/main/java/com/hubspot/singularity/SingularityUser.java b/SingularityBase/src/main/java/com/hubspot/singularity/SingularityUser.java
@@ -1,5 +1,7 @@
 package com.hubspot.singularity;
 
+import static com.google.common.collect.ImmutableSet.copyOf;
+
 import java.util.Objects;
 import java.util.Set;
 
@@ -18,7 +20,7 @@ public SingularityUser(@JsonProperty("id") String id, @JsonProperty("name") Opti
     this.id = id;
     this.name = name;
     this.email = email;
-    this.groups = groups;
+    this.groups = copyOf(groups);
   }
 
   public String getId() {