Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to s3UploaderAdditionalFiles #1000

Merged
merged 2 commits into from Jul 20, 2016
Merged

Tweaks to s3UploaderAdditionalFiles #1000

merged 2 commits into from Jul 20, 2016

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 15, 2016

  • Make the s3UploaderAdditionalFiles paths relative to the task directory, not the logrotate path
  • Allow the additional files to specify a glob

This should make things much more flexible and allow us to have something like an upload folder or other globs that match a wider range of things

/cc @tpetr

@ssalinas ssalinas modified the milestones: 0.6.0, 0.8.0 May 13, 2016
@ssalinas ssalinas modified the milestone: 0.8.0 Jun 16, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Jul 20, 2016

Another that has been working well, going to merge. Quick note that we'll need to add a short note in the next release on the change in configuration (ability to add a directory relative to task folder, default directory is the task folder, not logs now)

@ssalinas ssalinas merged commit 8624d89 into master Jul 20, 2016
1 of 2 checks passed
@ssalinas ssalinas deleted the upload_folder branch Jul 20, 2016
@ssalinas ssalinas added this to the 0.9.0 milestone Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants