Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to s3UploaderAdditionalFiles #1000

Merged
merged 2 commits into from Jul 20, 2016
Merged

Tweaks to s3UploaderAdditionalFiles #1000

merged 2 commits into from Jul 20, 2016

Conversation

@ssalinas
Copy link
Member

ssalinas commented Apr 15, 2016

  • Make the s3UploaderAdditionalFiles paths relative to the task directory, not the logrotate path
  • Allow the additional files to specify a glob

This should make things much more flexible and allow us to have something like an upload folder or other globs that match a wider range of things

/cc @tpetr

@ssalinas ssalinas added the hs_staging label Apr 27, 2016
@ssalinas ssalinas modified the milestone: 0.6.0 Apr 27, 2016
@ssalinas ssalinas force-pushed the upload_folder branch from e182bfb to 70720d0 Apr 27, 2016
…onal custom directory
@ssalinas ssalinas force-pushed the upload_folder branch from 70720d0 to 7ada27e Apr 27, 2016
@ssalinas ssalinas added the hs_qa label Apr 28, 2016
@tpetr

This comment has been minimized.

Copy link
Member

tpetr commented on 7ada27e May 5, 2016

🚢

@ssalinas ssalinas added the hs_stable label May 6, 2016
@ssalinas ssalinas force-pushed the upload_folder branch from c7c4802 to 147e502 May 9, 2016
@tpetr

This comment has been minimized.

Copy link
Member

tpetr commented on 147e502 May 9, 2016

🚢

@ssalinas ssalinas modified the milestones: 0.6.0, 0.8.0 May 13, 2016
@ssalinas ssalinas modified the milestone: 0.8.0 Jun 16, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Jul 20, 2016

Another that has been working well, going to merge. Quick note that we'll need to add a short note in the next release on the change in configuration (ability to add a directory relative to task folder, default directory is the task folder, not logs now)

@ssalinas ssalinas merged commit 8624d89 into master Jul 20, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssalinas ssalinas deleted the upload_folder branch Jul 20, 2016
@ssalinas ssalinas added this to the 0.9.0 milestone Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.