Skip to content

Changes to user requested task kills in custom executor#1006

Merged
ssalinas merged 5 commits into
masterfrom
task_kill
Jul 29, 2016
Merged

Changes to user requested task kills in custom executor#1006
ssalinas merged 5 commits into
masterfrom
task_kill

Conversation

@ssalinas

Copy link
Copy Markdown
Contributor

Two main changes in this:

  • For any user-requested kill (direct task kill, task destroy, also includes bounce at the moment), send a framework message to the executor to trigger the kill (if using a custom executor)
  • In the SingularityExecutor, don't skip to destroy if we receive a kill (framework message or normal) and there is already a kill process running

In the case when sending the framework message, I am still sending the normal kill as well (now that the executor handles it properly). This is so any other executors (default mesos or another custom) will still receive the kills they expect. I couldn't think of a better way around this since we do not have an easy way to determine that the executor is custom AND is a singularity custom executor, suggestions welcome for easier compatibility with other executors.

@wsorenson @tpetr

@wsorenson

Copy link
Copy Markdown
Contributor

I think we should only send the task destroy as a message.

@ssalinas

Copy link
Copy Markdown
Contributor Author

That makes sense. I'll keep it as regular kills for any other cases then

@ssalinas

ssalinas commented Apr 22, 2016

Copy link
Copy Markdown
Contributor Author

Updated to only use the framework message on a user initiated task destroy (which is now it's own task cleanup type to help differentiate it). Going to work with the task kill endpoint a bit more to make it clearer when a destroy will happen. Realized we can probably get it a bit cleaner than just using the override query param

@ssalinas ssalinas modified the milestone: 0.6.0 Apr 27, 2016
@ssalinas ssalinas added the hs_qa label Apr 28, 2016
@ssalinas ssalinas modified the milestones: 0.6.0, 0.8.0 May 13, 2016
@ssalinas ssalinas modified the milestone: 0.8.0 Jun 16, 2016
@ssalinas ssalinas modified the milestone: 0.10.0 Jul 29, 2016
@ssalinas

Copy link
Copy Markdown
Contributor Author

This has been doing well since the fix in #1141 , merging

@ssalinas ssalinas merged commit d054703 into master Jul 29, 2016
@ssalinas ssalinas deleted the task_kill branch July 29, 2016 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants