Conversation
Contributor
|
I think we should only send the task destroy as a message. |
Contributor
Author
|
That makes sense. I'll keep it as regular kills for any other cases then |
Contributor
Author
|
Updated to only use the framework message on a user initiated task destroy (which is now it's own task cleanup type to help differentiate it). Going to work with the task kill endpoint a bit more to make it clearer when a destroy will happen. Realized we can probably get it a bit cleaner than just using the override query param |
Fix user requested destroy when cleaning
Contributor
Author
|
This has been doing well since the fix in #1141 , merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two main changes in this:
In the case when sending the framework message, I am still sending the normal kill as well (now that the executor handles it properly). This is so any other executors (default mesos or another custom) will still receive the kills they expect. I couldn't think of a better way around this since we do not have an easy way to determine that the executor is custom AND is a singularity custom executor, suggestions welcome for easier compatibility with other executors.
@wsorenson @tpetr