Scroll to bottom of run now dialog #1011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the screen is too small, the 'Run now' button in the dialog will be off the screen, defeating the efforts to make this dialog one-click whenever possible.
With this change, the button will gain focus when the dialog is opened, causing the browser to automatically scroll to the button.
The timeout causes the button to focus again in half a second, which is necessary because Firefox ignores the first focus call (it's too close to trying to focus on the Vex dialog). There are two downsides to this: