Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email Colors Match UI Colors #1012

Merged
merged 1 commit into from May 3, 2016
Merged

Email Colors Match UI Colors #1012

merged 1 commit into from May 3, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Apr 28, 2016

This changes the color of the status bar in emails sent by Singularity to match the colors of the event being reported in the UI.

@@ -1,6 +1,18 @@
package com.hubspot.singularity;

public enum SingularityEmailType {
TASK_LOST, TASK_KILLED, TASK_FINISHED_SCHEDULED, TASK_FINISHED_LONG_RUNNING, TASK_FINISHED_ON_DEMAND, TASK_FINISHED_RUN_ONCE, TASK_FAILED, TASK_SCHEDULED_OVERDUE_TO_FINISH,
TASK_KILLED_DECOMISSIONED, TASK_KILLED_UNHEALTHY, REQUEST_IN_COOLDOWN, SINGULARITY_ABORTING, REQUEST_REMOVED, REQUEST_PAUSED, REQUEST_UNPAUSED, REQUEST_SCALED, TASK_FAILED_DECOMISSIONED
TASK_LOST("#D9534F"), TASK_KILLED("#777777"), TASK_FINISHED_SCHEDULED("#5CB85C"), TASK_FINISHED_LONG_RUNNING("#5CB85C"),
Copy link
Contributor Author

@Calvinp Calvinp May 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If at any point in the future it is desired to change the color of one of the email types, this is the place to change it.

@ssalinas
Copy link
Member

ssalinas commented May 3, 2016

Thanks @Calvinp , this looks good

@ssalinas ssalinas merged commit a9fa945 into master May 3, 2016
1 of 2 checks passed
@ssalinas ssalinas deleted the email-colors branch May 3, 2016
@ssalinas ssalinas modified the milestone: 0.6.0 May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants