New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only name of log file in aggregate tail title #1015

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Apr 28, 2016

The title of the aggregate log page was showing $TASK_ID when the task id was in the path to a log file.
This fixes that, and improves the title to only show the name of the file. The fully qualified path, which was displayed before, is usually not as useful as the name when looking at a tab preview, and it was pushing out the name itself since the space is so tiny.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 29, 2016

Member

Agreed that the file name is probably what we want there 👍

Member

ssalinas commented Apr 29, 2016

Agreed that the file name is probably what we want there 👍

@ssalinas ssalinas merged commit 5de9660 into master May 3, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@ssalinas ssalinas deleted the tail-of-log-name-in-title branch May 3, 2016

@ssalinas ssalinas modified the milestone: 0.6.0 May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment