New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the number of bad things on Status Page if they're 0 #1016

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Apr 28, 2016

Don't show:

  • Over provisioned requests
  • Under provisioned requests
  • Max task lag
    unless there actually are any to show.
Don't show the number of over-provisioned requests if it's 0. Same fo…
…r under-provisioned requests and task lag
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 29, 2016

Member

This looks good, thanks @Calvinp

Member

ssalinas commented Apr 29, 2016

This looks good, thanks @Calvinp

@ssalinas ssalinas merged commit c9b4845 into master May 3, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@ssalinas ssalinas deleted the dont-show-negatives-that-dont-exist-on-status-page branch May 3, 2016

@ssalinas ssalinas modified the milestone: 0.6.0 May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment