Tasks page improvements #1017
Tasks page improvements #1017
Conversation
… they share a template
… of a particular rack from the rack column
| </li> | ||
| <li {{#ifEqual tasksFilter "scheduled"}}class="active"{{/ifEqual}}> | ||
| <a href="{{appRoot}}/tasks/scheduled">Scheduled</a> | ||
| <a href="{{appRoot}}/tasks/scheduled" class='has-tooltip' title="Tasks that will run when the time comes" data-toggle='tooltip'>Scheduled</a> |
There was a problem hiding this comment.
Maybe more like 'Tasks that will run at the next scheduled interval'
| @@ -40,6 +40,7 @@ Handlebars.registerHelper 'ifTaskInList', (list, task, options) -> | |||
| return options.inverse @ | |||
|
|
|||
| Handlebars.registerHelper 'ifInSubFilter', (needle, haystack, options) -> | |||
| #return options.inverse @ unless haystack | |||
There was a problem hiding this comment.
there a reason this comment was added?
There was a problem hiding this comment.
Artifact of one way I considered to fix a problem I was having. I'll remove it.
| </th> | ||
| <th class="hidden-xs" data-sort-attribute="host"> | ||
| Host | ||
| </th> | ||
| <th class="hidden-xs" data-sort-attribute="taskId.rackId"> | ||
| <th class="visible-lg" data-sort-attribute="taskId.rackId"> |
There was a problem hiding this comment.
What was the reasoning for making this visible vs not and lg vs xs? I would argue that just seeing the task id, cpu and mem on a small device is the more important. And probably host over rack if we were to choose one more to add
There was a problem hiding this comment.
Honestly, I just chose the one I saw first as the correct one. There probably won't be room for hosts on a smaller screen if we want to show disk resource too though.
There was a problem hiding this comment.
If you have the bandwidth it'd be worth a quick pass over the bootstrap classes for the table columns to make sure they collapse nicely (e.g. are xs and lg good breakpoints or is sm better? What are the most important to display and what can we hide?). If I remember correctly, visible-lg is actually deprecated as of 3.2 in favor of visible-(size)-(display style)
There was a problem hiding this comment.
I'll take a look at this now.
There was a problem hiding this comment.
At the smallest window sizes, the task ID and started at timestamp start running off the screen. But that happens regardless of what we're showing. hidden-xs seems to be ok - everything is able to display pretty much the same at the smaller sizes down to the xs cutoff. It might not be ok for a table with more columns though. Also, the actions icons (kill task and JSON) can fit without causing a change in the way the rest of the table looks even at the smallest sizes.
There was a problem hiding this comment.
Also, the actions icons (kill task and JSON) can fit without causing a change in the way the rest of the table looks even at the smallest sizes.
This does not appear to be the case, however, on the other tasks tables. Only on active. So I'm going to remove hidden-xs for the actions icons for active tasks only.
|
One more comment on this. When in a filter that isn't |
|
As it turns out, pending tasks don't store their request type - you'd have to fetch the task to acquire that, which is certainly not reasonable to do for every single task. |
|
Looks good @Calvinp , the new toggles are much nicer/easier |
Implements several improvements to the tasks table page:
Namefield is changed toTask IDandStartedis changed toStarted At