Conversation
SingularityUI/app/utils.coffee
Outdated
| splits = taskId.split('-') | ||
| splits[splits.length - 3] | ||
|
|
||
| @getDeployIdFromTaskId: (taskId) -> |
Member
There was a problem hiding this comment.
I think it might be a bit cleaner and more reusable to have a model for the TaskId. i.e. have something like a fromString method for the taskId model to set the attributes. Reusable where we need it, and you are then only calling the split once when you build the object instead of multiple times for the same string
…, to avoid having to split the taskId over and over
Member
|
LGTM |
ssalinas
deleted the
aggregate-tailer-tooltip-host-on-instance-count-and-maybe-tasks-dropdown
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a tooltip showing the host and deploy id on the instance number in the aggregate tailer, and one showing only the host on the dropdown showing all the tasks.