Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate tailer better handle logs not found #1026

merged 2 commits into from May 11, 2016


Copy link

@Calvinp Calvinp commented May 5, 2016

Change the tailer to not send extra requests when we already know the task file doesn't exist, and to only show the name of the file in the 'does not exist' message.

promises = ({taskId, maxOffset, path, initialDataLoaded}) ->
if initialDataLoaded
promises = ({taskId, exists, maxOffset, path, initialDataLoaded}) ->
if initialDataLoaded and exists isnt false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing this to false is on purpose - if exists is undefined, we may just not know yet if the file exists or not. If it's false, we know for sure the file doesn't exist.

@ssalinas ssalinas modified the milestone: 0.6.0 May 6, 2016
@ssalinas ssalinas merged commit 5f2e376 into master May 11, 2016
@ssalinas ssalinas deleted the aggregate-tailer-better-handle-logs-not-found branch May 11, 2016 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants