Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate tailer better handle logs not found #1026

Merged
merged 2 commits into from May 11, 2016

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented May 5, 2016

Change the tailer to not send extra requests when we already know the task file doesn't exist, and to only show the name of the file in the 'does not exist' message.

promises = tasks.map ({taskId, maxOffset, path, initialDataLoaded}) ->
if initialDataLoaded
promises = tasks.map ({taskId, exists, maxOffset, path, initialDataLoaded}) ->
if initialDataLoaded and exists isnt false

This comment has been minimized.

Copy link
@Calvinp

Calvinp May 5, 2016

Author Contributor

Comparing this to false is on purpose - if exists is undefined, we may just not know yet if the file exists or not. If it's false, we know for sure the file doesn't exist.

@ssalinas ssalinas modified the milestone: 0.6.0 May 6, 2016
@ssalinas ssalinas added the hs_stable label May 11, 2016
@ssalinas ssalinas merged commit 5f2e376 into master May 11, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the aggregate-tailer-better-handle-logs-not-found branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.