Aggregate tailer better handle logs not found #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 5, 2016 10:16
… task's directory" if appropriate
| promises = tasks.map ({taskId, maxOffset, path, initialDataLoaded}) -> | ||
| if initialDataLoaded | ||
| promises = tasks.map ({taskId, exists, maxOffset, path, initialDataLoaded}) -> | ||
| if initialDataLoaded and exists isnt false |
There was a problem hiding this comment.
Comparing this to false is on purpose - if exists is undefined, we may just not know yet if the file exists or not. If it's false, we know for sure the file doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change the tailer to not send extra requests when we already know the task file doesn't exist, and to only show the name of the file in the 'does not exist' message.