Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Request and Deploy ID Validation #1031

Merged

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented May 6, 2016

Reject more characters from request IDs and deploy IDs to prevent tasks from being created that can either never be run in Mesos or would have URLs that can't be visited.

…ng characters that Mesos doesn't allow, or that would cause problems visiting the URL of the request or deploy
@ssalinas ssalinas added the hs_stable label May 12, 2016
@ssalinas ssalinas modified the milestone: 0.8.0 May 13, 2016
@tpetr tpetr merged commit d2776b8 into master Jun 7, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@tpetr tpetr removed hs_qa labels Jun 7, 2016
@ssalinas ssalinas deleted the reject-more-bad-characters-from-request-and-deploy-ids branch Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.