New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scale during deploy #1037

Merged
merged 5 commits into from May 17, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented May 13, 2016

@stevenschlansker should fix that edge case you ran into the other day when scaling + deploying at the same time

@ssalinas ssalinas added this to the 0.6.0 milestone May 13, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr May 13, 2016

Member

Could you add a unit test for this?

Member

tpetr commented May 13, 2016

Could you add a unit test for this?

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas May 13, 2016

Member

test added

Member

ssalinas commented May 13, 2016

test added

@ssalinas ssalinas added the hs_qa label May 16, 2016

@ssalinas ssalinas added the hs_stable label May 16, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas May 17, 2016

Member

Found one last hitch with scale during deploy. If the timing is right, you will end up with the pre-scale number of requests running after the deploy is finished. The deploy ends with the targetActiveInstances, but we currently don't enqueue another pending request on successful deploy. Going to extend the test to check for this case then figure out the best way to fix it

Member

ssalinas commented May 17, 2016

Found one last hitch with scale during deploy. If the timing is right, you will end up with the pre-scale number of requests running after the deploy is finished. The deploy ends with the targetActiveInstances, but we currently don't enqueue another pending request on successful deploy. Going to extend the test to check for this case then figure out the best way to fix it

@ssalinas ssalinas changed the title from avoid index out of bounds when finding tasks to shut down to Handle scale during deploy May 17, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr May 17, 2016

Member

LGTM

Member

tpetr commented May 17, 2016

LGTM

@ssalinas ssalinas merged commit 4a3fdb8 into master May 17, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@ssalinas ssalinas deleted the avoid_oob branch May 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment