Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle scale during deploy #1037
Conversation
ssalinas
added this to the 0.6.0 milestone
May 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Could you add a unit test for this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
test added |
ssalinas
added
the
hs_staging
label
May 13, 2016
ssalinas
added
the
hs_qa
label
May 16, 2016
ssalinas
added
the
hs_stable
label
May 16, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
ssalinas
May 17, 2016
Member
Found one last hitch with scale during deploy. If the timing is right, you will end up with the pre-scale number of requests running after the deploy is finished. The deploy ends with the targetActiveInstances, but we currently don't enqueue another pending request on successful deploy. Going to extend the test to check for this case then figure out the best way to fix it
|
Found one last hitch with scale during deploy. If the timing is right, you will end up with the pre-scale number of requests running after the deploy is finished. The deploy ends with the targetActiveInstances, but we currently don't enqueue another pending request on successful deploy. Going to extend the test to check for this case then figure out the best way to fix it |
ssalinas
changed the title from
avoid index out of bounds when finding tasks to shut down
to
Handle scale during deploy
May 17, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
LGTM |
ssalinas commentedMay 13, 2016
@stevenschlansker should fix that edge case you ran into the other day when scaling + deploying at the same time